joyride icon indicating copy to clipboard operation
joyride copied to clipboard

Published 20 hours ago • verified publisher icon BetterThanTomorrow

Minor suggestions to simplify the code

Open erickisos opened this issue 2 years ago • 3 comments

erickisos avatar Jun 07 '22 14:06 erickisos

Thanks! It'll take us a while before we get to merging this. We need some automatic testing in place so that we can ask you to add tests. 😄

PEZ avatar Jun 07 '22 15:06 PEZ

Hey @PEZ !

If you agree, I can create a PR to start adding tests, are we willing to use kaocha? it seems like we are working with babashka and clj, so it seems like the best approach

erickisos avatar Jun 07 '22 16:06 erickisos

I think we should figure out first what kinds of tests we're going to write, preferably integration tests and perhaps in joyride itself. @PEZ and I are still contemplating this.

borkdude avatar Jun 07 '22 16:06 borkdude

We've updated our PR template (.github/pull_request_template.md) and contribution process (CONTRIBUTE.md). Refactorings like this should be preceded with an issue that contains a problem statement. If you think it's still worth submitting a PR after reviewing these documents, feel free to reach out.

borkdude avatar Jan 07 '23 11:01 borkdude