BetonQuest icon indicating copy to clipboard operation
BetonQuest copied to clipboard

Position bug of the player with a mount

Open AxDevv opened this issue 2 years ago • 2 comments

Confirm the following

  • [X] I use the latest release or dev-build. I also checked that this problem hasn't already been fixed in a newer dev-build.
  • [X] There are no open or closed issues that are related to my problem.

BetonQuest version information

BetonQuests DEV 2.0.0-DEV-442 Server PurPur-1825 1.19.2

Expected behaviour

If a player uses a mount, it is not removed and can be used to take a quest or removed to avoid bugs.

Actual behaviour

When a player takes a quest with a mount (horse for example) this one makes bug the position of the player and the mount thinks we are still on it

Steps to reproduce

https://www.youtube.com/watch?v=WluCPKhGmAc

Error, Warning, Exception or Thread Dump

No response

Additional information

https://www.youtube.com/watch?v=WluCPKhGmAc

AxDevv avatar Nov 09 '22 13:11 AxDevv

Ok i can confirm the issue. If a player is mounted on an entity, and the player enters a Conversation, the player is mounted on the armorstand, but only client side. If the player press shift, he is dismounted, but also only client side. So for the server he is still on the entity mounted.

Possible solutions:

  1. Disallow conversations while mounted on an entity
  2. Dismount the player from the entity (maybe the entity can then be stolen)
  3. Let the player mounted

For solution 3 we need to adjust the position for the armorstand while the player is still on the entity riding it, so the height makes more sense. After the conversation, we need to remount the player on the original entity. (problem, may the entity continue traveling in a direction, this is may a bigger issue for conversations with stop true)

Wolf2323 avatar Nov 09 '22 14:11 Wolf2323

Or why not add a feature that would allow to check if the player is already on a mount, and directly freeze the mount in question during the dialogue?

AxDevv avatar Nov 09 '22 14:11 AxDevv