Beisi Zhou

Results 58 comments of Beisi Zhou

Could you explain what's your purpose to do this customization so that we can check whether your PR is the correct way to do so?

> Hide the 2 cmdlets Get-AzNetworkFunctionAzureTrafficCollectorsByResourceGroup and Get-AzNetworkFunctionAzureTrafficCollectorsBySubscription, and add 1 cmdlet Get-AzNetworkFunctionAzureTrafficCollector_List. We want to add 2 parameter sets, 1 is for Get and 1 is for List. As...

> I have made this change in the Readme. I see 2 cmdlets generated, is this correct? Yes, they should be from OperationId AzureTrafficCollectorsBySubscription_List and AzureTrafficCollectorsByResourceGroup_List. Does current Get-AzTrafficCollectors match...

> Just 1 question - is there a reason why this isn't part of the automated pipeline in Powershell? If this is a common scenario needed by multiple teams, is...

That's good. We have two options now. - Wait for swagger change finished. And then update the commid id in README.md. - Or modify swagger by directive of autorest.powershell. Which...

Let me convert current PR as draft and please mark it as ready when the commit id comes.

So does New-AzNetworkFunctionCollectorPolicy include Location now? If so, please run autorest and ./build-module.ps and commit all changes to your remote branch

Per my knowledge, the way to make parameter mandatory is via customization: 1. Hide New-AzNetworkFunctionCollectorPolicy by directive 2. Copy New-AzNetworkFunctionCollectorPolicy.ps1 from internal folder to custom folder 3. Add attribute mandatory...

> We have followed PS guidelines and checked in all needed files I haven't found the changes for syntax of docs/New-AzNetworkFunctionCollectorPolicy.md and docs/Get-AzNetworkFunctionTrafficCollector.md. Please have a look. Also, we'd better...

like @isra-fel said, the best way is marking Location in TrackedResource as required. Is it doable?