geeqie icon indicating copy to clipboard operation
geeqie copied to clipboard

Double-clicking a thumbnail to make image fullscreen immediately switches to the next image

Open HolyBlackCat opened this issue 1 year ago • 3 comments

Setup (please complete the following information):

  • Distribution: Arch
  • Distribution release: :upside_down_face:
  • Geeqie version [geeqie --version]: Geeqie 2.4 GTK3

Describe the bug

Double-clicking a thumbnail is supposed to open that image fullscreen. It does that, but it also immediately switches to the next image.

If you click slowly, you can see that pressing the mouse the second time opens the fullscreen, and then releasing it switches the image.

To reproduce Steps to reproduce the behavior:

  • Double-click a specific image thumbnail.
  • Observe the immediate switch to the next image.

Expected behavior Double-clicking a thumbnail should just open that image fullscreen, and not switch to the next one.

HolyBlackCat avatar Jun 14 '24 07:06 HolyBlackCat

I think this is because of an option that causes a confliction.

Go to Edit/Preferences/Behaviour and unset Navigation By Left Or Middle Click On Image

caclark avatar Jun 14 '24 08:06 caclark

@caclark But I do want the left-click to switch to the next image. It just must not happen when first opening fullscreen. If the option exists in the first place, it should work correctly.

Moreover, I think I'm using the default settings (but I could be wrong here).

HolyBlackCat avatar Jun 14 '24 11:06 HolyBlackCat

The problem exists because the project has evolved, rather than being a from-scratch consistent design. The click-for-next-image came first, and the double-click for full-screen came next.

The solution is to delay processing of a single click until the double-click time has elapsed. That is possible, but is not so trivial because the code in that section would no longer be linear. If the user has set a long double-click time, they will see that delay before the next image is displayed.

Until it is fixed the mouse-only possibilities are to unset Navigation By Left Or Middle Click On Image and use the mouse wheel to move next/previous image, or use the right-click menu.

Moreover, I think I'm using the default settings (but I could be wrong here).

Yes, that is true. When the click-for-next-image code was implemented, it was set as the default. I did not want to change default settings.

caclark avatar Jun 14 '24 15:06 caclark