django-super-inlines icon indicating copy to clipboard operation
django-super-inlines copied to clipboard

unknow-icon.gif missing with Django 1.9

Open bdesbiolles opened this issue 9 years ago • 1 comments

Hi,

with Django 1.9, some static images have changed like unknow-icon.gif which is know unknow-icon.svg. This causes graphical glitches (missing icon).

This image is used by super_inlines/templates/admin/edit_inline/tabular.html at line 19.

From where I stand I see two quick solutions:

  • change icon-unknown.gif to icon-unknown.svg and bump the version number (breaking compatibility).
  • add the image within the project static files to keep compatibility.

I can contribute to the project, I just wanted an opinion before submitting a PR directly.

Thanks,

Baptiste

bdesbiolles avatar Aug 24 '16 14:08 bdesbiolles

IMHO, it's best to update the reference and push the version. Copying files from django in order to support older, unsupported (by upstream) versions is too dirty.

WhyNotHugo avatar Aug 24 '16 15:08 WhyNotHugo