Bert Roos

Results 76 comments of Bert Roos

@richardwu When creating the pull request, did you check the box "[Allow edits from maintainers](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork)"? If not, can you enable it as described [here](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests)? Then I can add the code...

@richardwu Taking a closer look, I wonder why you need the extra configuration settings. Can't you configure the AWS IAM using the configuration described in the readme? > Rather than...

@richardwu Given that the implementation approach is very different, I created a new PR: #516. Can you review and test it? After testing, you'll have a complete configuration for AWS...

@richardwu Can you respond to my previous comment?

@richardwu Can you paste the command you use to run Kafdrop?

That's strange. This is my output: ``` mvn clean package [INFO] Scanning for projects... [INFO] [INFO] ----------------< com.obsidiandynamics.kafdrop:kafdrop >---------------- [INFO] Building kafdrop 4.0.0-SNAPSHOT [INFO] from pom.xml [INFO] --------------------------------[ jar ]---------------------------------...

I see. Look at this in your output: ``` Caused by: org.apache.kafka.common.config.ConfigException: Invalid value software.amazon.msk.auth.iam.IAMClientCallbackHandler for configuration sasl.client.callback.handler.class: Class software.amazon.msk.auth.iam.IAMClientCallbackHandler could not be found. ``` Apparently, you have a local...

Can you be more specific? The purpose of Kafdrop is to look into Kakfa, so your request sounds like the opposite of the purpose. What about not running Kafdrop in...

So you want to browse the topics, etc. but not the message content. There is no configuration option for that, but you might be able to accomplish what you want...

Though it's true that this folder is not being used during the verification, I don't see any practical benefit in adding this condition, as the performance overhead of copying these...