[Bug]: "log_event_type" reported in custom callbacks for calls that reach max_parallel_requests no longer "failed_api_call" but instead "post_api_call"

[jeromeroussin]

What happened?

Sometime between 1.52.16 and 1.53.1, the way reaching max_parallel_requests is handled changed from a "failed_api_call" to a "post_api_call". This breaks my tests, but more importantly it does not strike me as the proper label. "aync_log_failure_event" is still properly called, but "event_log_type" no longer matches the fact the call failed.

Relevant log output

No response

Twitter / LinkedIn details

https://www.linkedin.com/in/jeromeroussin/

[krrishdholakia]

the way reaching max_parallel_requests changed from a "failed_api_call" to a

not sure i follow here. what do you mean 'reaching max_parallel_requests changed' ?

[jeromeroussin]

Right, a few words missing. I edited the wording.

[ishaan-jaff]

Noting this as a P1 issue - when seeing max parallel request limit

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.