(fix) Unable to override max_retries for Azure and Groq (#6138)

[ishaan-jaff]

Title

Relevant issues

Type

🆕 New Feature 🐛 Bug Fix 🧹 Refactoring 📖 Documentation 🚄 Infrastructure ✅ Test

Changes

[REQUIRED] Testing - Attach a screenshot of any new tests passing locall

If UI changes, send a screenshot/GIF of working UI fixes

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
litellm	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 10, 2024 10:50am

[ishaan-jaff]

Hi @magaman384 seeing this error on your PR

AzureException APIError - Completions.create() got an unexpected keyword argument 'max_retries' LiteLLM Retried: 2 times, LiteLLM Max Retries: 3

[magaman384]

Hi @magaman384 seeing this error on your PR

AzureException APIError - Completions.create() got an unexpected keyword argument 'max_retries' LiteLLM Retried: 2 times, LiteLLM Max Retries: 3

Hi, thanks I'll try to fix it, however I had quite hard time running all the tests locally. Is it supposed to work according the README.md? Because it seems like lot of dependencies are missing (e.g. I get errors like PytestUnknownMarkWarning: Unknown pytest.mark.asyncio - is this a typo?). Would be helpful if I could run them on my machine.

[magaman384]

@ishaan-jaff Hey! With some reverse engineering I've managed to fix the failing test after all, here is a commit that fixes it: https://github.com/BerriAI/litellm/pull/6285/commits/b8c9515b1590b067cd86a9b538731dcae00fe7bd

I've also created a separate PR for that from my fork, wasn't sure if you want to just cherry-pick into this one. Probably would be easier not to cherry-pick since I've rebased the new PR and resolved all the conflicts.

[kiriloman]

@krrishdholakia Hey Krish, could you have a look at this bug fix https://github.com/BerriAI/litellm/pull/6285? It is an extension of this PR and is resulting in incorrect behaviour for Azure, Groq, etc. when setting retries.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.