litellm icon indicating copy to clipboard operation
litellm copied to clipboard

[Bug]: S3 Logging seems dead on `default_team_settings` teams

Open Manouchehri opened this issue 10 months ago • 4 comments

What happened?

We've already talked about this over Discord, but figured I should make a proper ticket instead of bugging you every few weeks. =P

Here's my config:

litellm_settings:
  telemetry: False
  # set_verbose: True
  drop_params: True
  cache: True
  cache_params:
    type: s3
    s3_bucket_name: os.environ/CACHING_S3_BUCKET_NAME
    s3_region_name: os.environ/CACHING_AWS_DEFAULT_REGION
    s3_aws_access_key_id: os.environ/CACHING_AWS_ACCESS_KEY_ID
    s3_aws_secret_access_key: os.environ/CACHING_AWS_SECRET_ACCESS_KEY
    s3_endpoint_url: os.environ/CACHING_AWS_ENDPOINT_URL_S3
  failure_callback: ["sentry", "langfuse"]
  num_retries_per_request: 3
  success_callback: ["langfuse", "s3"]
  s3_callback_params:
    s3_bucket_name: os.environ/LOGGING_S3_BUCKET_NAME
    s3_region_name: os.environ/LOGGING_AWS_DEFAULT_REGION
    s3_aws_access_key_id: os.environ/LOGGING_AWS_ACCESS_KEY_ID
    s3_aws_secret_access_key: os.environ/LOGGING_AWS_SECRET_ACCESS_KEY
    s3_endpoint_url: os.environ/LOGGING_AWS_ENDPOINT_URL_S3
  default_team_settings:
    - team_id: david_dev
      success_callback: ["langfuse", "s3"]
      langfuse_secret: os.environ/LANGFUSE_PRIVATE_KEY_DAVID
      langfuse_public_key: os.environ/LANGFUSE_PUBLIC_KEY_DAVID

Note: I do have the AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY environmental variables set, but those are only for Bedrock. I'm not using AWS S3 for the bucket.

Relevant log output

No response

Twitter / LinkedIn details

https://www.linkedin.com/in/davidmanouchehri/

Manouchehri avatar Apr 05 '24 02:04 Manouchehri

It looks like S3 caching is working with default_team_settings. It's just the logging that's dead at the moment.

Manouchehri avatar Apr 11 '24 21:04 Manouchehri

@Manouchehri we have testing for team-based logging with langfuse, it seems to work fine

Server logs here would be helpful!

krrishdholakia avatar Apr 20 '24 19:04 krrishdholakia

Team-based logging with langfuse works fine for me. It's only the S3 part that doesn't.

Manouchehri avatar Apr 20 '24 19:04 Manouchehri

@krrishdholakia Could you try making a request that fails with team based logging? Not sure I'm doing something wrong, but that seems to be broken on Langfuse too (while successful calls are logged properly with Langfuse).

Manouchehri avatar Apr 23 '24 13:04 Manouchehri

It looks like this was somehow fixed in v1.38.10. I see our logs working again.

Manouchehri avatar Jun 13 '24 20:06 Manouchehri