litellm
litellm copied to clipboard
Don't depend on uvloop on windows
Fixes #7731
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| litellm | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 1, 2025 9:56pm |
This also needs conditional import logic like https://github.com/aviadr1/winuvloop/blob/main/winuvloop/init.py
However, the lint rule is failing because it looks like the regex is too strict?
Edit: never mind, fixed it.
On second thoughts maybe it's better just to swap the uvloop dependency with winuvloop and let it do the logic?
I found out that we don't even import uvloop on windows, so the fix is just to make the build-time dependency conditional on not being windows. As we don't need winloop, we don't need winuvloop either.
This is ready to merge, thanks
@ishaan-jaff Hi, this one-liner fixes the windows install, please can we merge?
We are also interested in this PR being merged
We are also interested in this PR being merged
Same here!
If you use uv to manage dependencies, there is another solution before this PR merged.
[tool.uv]
override-dependencies = ["uvloop;sys_platform != 'win32'"]
@ishaan-jaff Hi again, there are a quite a lot of people using windows who are stuck on months-old versions of litellm without this fix, please can we merge? Thanks
thanks @sparkprime, accepted !