LD-ToyPad-Emulator icon indicating copy to clipboard operation
LD-ToyPad-Emulator copied to clipboard

Suggestion: Upload personal images for each token

Open Luigimeansme opened this issue 1 year ago • 8 comments

I understand we've discussed having images assigned to the characters and vehicles in #44, and completely understand not wanting to mess with copyright shenanigans. I did have an idea, however; add in the ability to upload images that you have on your device to assign them to the character or vehicle you're trying to create. Here's how I'm imagining this going down; -You are making your characters for the first time by selecting them in the drop-down menu. When you click the "Create Character" or "Create Vehicle" button, a little button pops up asking if you'd like to upload an image. If you say yes, you get taken to your file finder and can select the image that'll be shown in the ToyBox. If you say no, it just goes into the ToyBox as it currently looks.

This way, we can choose whether or not we use images, and it's no risk to you because they have to be supplied by the user, and it doesn't even have to be the correct image. It can be any image you choose to represent that particular token

Luigimeansme avatar Oct 18 '22 05:10 Luigimeansme

There should be some original images built in for those who don't own any LD figures and are too lazy to whip up a pictogram for each

spudpiggy avatar Dec 16 '22 12:12 spudpiggy

@spudpiggy Links to externally hosted images would be OK, I think. But there will not be any copyrighted images uploaded to this repository. Big companies like Lego love to send DMCA take-downs.

Berny23 avatar Dec 16 '22 15:12 Berny23

@spudpiggy Links to externally hosted images would be OK, I think. But there will not be any copyrighted images uploaded to this repository. Big companies like Lego love to send DMCA take-downs.

I understood the copyright issue, that's why I suggested the option to upload images for your own personal version that you have to supply yourself. The original repository isn't edited or supplying copyrighted images, it's just the user wanting to customize their experience

Luigimeansme avatar Dec 16 '22 21:12 Luigimeansme

There might be a logic that images will be expected in definite directory with predefined names/format/sizes. If token image file exists webpage will render it, otherwise token will be presented "the old way" :)

So, anybody can handle their own collection without publishing it here.

VladimirKuletski avatar Dec 17 '22 15:12 VladimirKuletski

There might be a logic that images will be expected in definite directory with predefined names/format/sizes. If token image file exists webpage will render it, otherwise token will be presented "the old way" :)

So, anybody can handle their own collection without publishing it here.

You should also be able to add image links via the webui, which are then stored in a JSON file. You can then export/import the file using the site.

spudpiggy avatar Dec 19 '22 07:12 spudpiggy

I would love to point to an img from a hoster to make it easier to figure out who they are talking about in the game. As I’m playing with my kids, I have to look at info and read the names and it’s time consuming. If I can see the image, that would make it so much easier to pick who they are talking about right away.

FrankTheTank908 avatar Jun 22 '23 07:06 FrankTheTank908

Why did you bump an 8 month old issue lmao

spudpiggy avatar Jun 22 '23 14:06 spudpiggy

Why did you bump an 8 month old issue lmao

Should I just make another post? No, might as well put it in here. I didn’t know discussions were open on this GitHub. So I made a post there. Your the type of person that will make many posts even though there are ones open already.

FrankTheTank908 avatar Jun 22 '23 14:06 FrankTheTank908