berkie_menu
berkie_menu copied to clipboard
A few suggestions/bugs i have
- Misc > Menu Position doesnt seem to do anything (it only applies to new menus, Recording Options, World Related Options, specific player in Online Players)
- Misc > Display Location gives an error (@bMenu/client/menus/misc/main.lua:173: attempt to perform unsupported operation on a vector value (local 'currentPos'))
- Vehicle > Personal Vehicle Options > Set Vehicle creates a second Current Vehicle option
- Restarting the menu over and over will completely brick it for everyone other than the person restarting it
- Online Players > Player > Kill doesnt work on others
- Noclip speed doesnt live update, but will show correct speed when turned on
Misc > Menu Position doesnt seem to do anything (it only applies to new menus, such as the recording one)
This is because ox_lib only applies the menu position when a menu is reopened.
Misc > Menu Position doesnt seem to do anything (it only applies to new menus, such as the recording one)
This is because ox_lib only applies the menu position when a menu is reopened.
even when reopening the main menu it stays in top-right
Oh then it's probably because of how the menus are registered, the ones that it doesn't apply to are the ones that are static registered
But with the permissions system most (or all) menus should be registered newly after everytime it should open
also just found that after restarting the menu a few times everyone else on the server will lose the menu entirely but the person that restarted it will still be able open it
Probably a case of the MenuOpen variable not resetting properly or something with ox_lib
like the weather & time breaks as well when this happens
Oh, so the whole code basically breaks then
yeah thats what it seems like
Killing other players doesnt work either, but it works on yourself
Might be because of it being client side, this is where vMenu is outdated
Noclip speed doesnt live update, but will show correct speed when turned on
That worked last time I tried it, or I don't remember it lol
let me rephrase, the text that says what speed doesnt update until turning it off and on
Yeah I understood that
I've committed https://github.com/BerkieBb/bMenu/commit/2661b72fd22391b80ba77f13fbcd416fee2cf62a to ensure the menu position does set on the main menu, all other menus with perms are already re-registered each time the perms are checked, so those are good already. Now I need to finish the perms to make sure other menus do set the menu position too.
https://github.com/BerkieBb/bMenu/commit/e2ca668d93121dae4aadf8e2edf11cf095c23f99 This should fix your Display Location error
going to start working on this again, is there a todo list somewhere?
Still in client/main.lua