BerkeleyLab
Test with Julienne and Gfortran 15
This PR
- Creates Julienne unit tests in
test/juliennethat replace corresponding veggies tests intest/. - Completes approximately 40% of the transition to Julienne in terms of lines of code.
- Adds a Julienne test driver in
test/julienne/driver.F90. - Maintains coverage such that the Julienne tests + the Veggies tests = the Original Veggies tests.
The decision about which tests to prioritize for transitioning first was driven by file size with the work progressing from the smallest file to the largest file. A couple of relatively minor features have been added in Julienne 3.1.0 in order to support Caffeine, but there no known issues preventing continuing this process with the remaining tests. At this point, the only known hurdle is available developer time.
I removed the GASNet install trees, but now I notice other stray files that appear to have also been inadvertently added. I'll assume I also have your permission to remove those.
@bonachea I fixed the issue that was causing failures. All tests pass now. This PR is ready for review.
As discussed in our meeting today, git has a hard time following file renames that include content changes, which unfortunately initially made this PR's diffs unreadable. This is the reason Caffeine's coding conventions require file renames to occur in an isolated commit (preferably in an isolated PR). In this case it didn't seem like the renames were critical to the main point of the PR, so as agreed verbally today, I've just pushed commit a41bde2f reverting the file renames (with no content changes), which successfully restored readable diffs.
We can always rename files later in a subsequent PR that omits content changes, assuming there's a compelling motivation for it.
CI tests are still passing, and I hope to find time to review this PR next week.
@bonachea sounds good. I really like Caffeine's coding conventions and hadn't noticed them before.
@bonachea is this PR ready to merge? GitHub indicates that there is one change requested but when I click the link to see the requested change, I get the message "We went looking everywhere, but couldn’t find those commits."