BentoBox icon indicating copy to clipboard operation
BentoBox copied to clipboard

No way to set spawn island range

Open tastybento opened this issue 4 years ago • 5 comments

Description

Describe the bug

The spawn island range cannot be set.

Steps to reproduce the behavior

Create a spawn island using setspawn. Try to change the range - it requires a player name.

Expected behavior

It should be possible for an admin to set the spawn range. For example:

/bsb range setspawn 400

There is a workaround using registration.

tastybento avatar Oct 18 '19 05:10 tastybento

I disagree on creating a specific subcommand for this. It might be worth adding "selectors" like Minecraft's: @spawn for the spawn, @here for the island the admin is standing on, @all/@a to apply the change to all islands. What do you think about this?

About the issue itself: I think it's rather a missing or misdesigned feature than an actual bug.

Poslovitch avatar Oct 20 '19 07:10 Poslovitch

Actually, we use a registered island as a spawn one. Our server owner owns it.

/island spawn command works as intended and the range is also expandable. I think I have read somewhere that you are going to make spawn islands not able to be both registered and spawn flagged. I see no special reason for that feature (not a bug) to be gone.

I suppose I typed this in the wrong issue, but I hadn't seen a previous one I had described

wellnesscookie avatar Oct 20 '19 13:10 wellnesscookie

@wellnesscookie I see what you are saying, but in that case, there is no way to "unspawn" an island. Both situations currently have problems. Either spawn islands are always unowned and we add a way to change the range, or spawn islands are owned but we add a way to remove the spawn setting from them.

Even if we allow spawn islands to be owned, it will be necessary to enable unowned islands to be spawn, so the command to set the range of the spawn island is required no matter what. It will also be necessary to add the ability to unspawn an island, so that should be added too. I think we can adopt this approach, but we need both of these things to be done in that case. Further, the code that removed spawn from an island if it is registered to someone can be removed.

On the other hand, if we insist that spawn islands cannot be owned, then we only need to add the ability to set the range, and that will be enough. So, technically, this is less work.

However, I think it's probably a bit too arbitrary to require spawn islands to be unowned, so I'm okay with enabling it. The work must be done though.

tastybento avatar Jan 08 '20 00:01 tastybento

Understood, I'm okay with any of solutions you said then. Though there is a problem at the moment, protection range if expanded by permission is also removed if the leader of that island with that permission is changed. That means the ranges are leader (player) sensitive, while island spawn will not be. Could that part of code be used to implement ranges to be island-sensitive? Other solutions I see is to respect range permission of everyone in the team and not just a leader (pick highest found)

wellnesscookie avatar Jan 08 '20 05:01 wellnesscookie

Spawn island range could be set to ignore permissions. I think that's the best approach.

tastybento avatar Jan 08 '20 22:01 tastybento