BentoBox icon indicating copy to clipboard operation
BentoBox copied to clipboard

Improve permission prefix behavior for commands

Open BONNe opened this issue 6 years ago • 2 comments

Is your feature request related to a problem? Please describe. Currently, for add-ons that are integrated into other add-ons, like challenges and biomes, add-on permission prefix is kinda useless. It basically works only for add-ons, that create their own commands.

Describe the solution you'd like Add-ons permission prefix should be used when creating CompositeCommand. It should be added after parent permission prefix. (and as commands from single addon can be parents of subcommands, then permission prefix should not be doubled). f.e. Set challenges as Challenges addon permission prefix. All permissions for skyblock should be like: bskyblock.challenges.*.

Describe alternatives you've considered Manually change permission prefix on initializing first parent command.

Additional context This is necessary so users could specify which command cooldowns users could skip. Currently, it is not possible to say, that user can skip creating island cooldown, but they should wait for changing biomes, as skipping is managed by single permission: getPermissionPrefix() + ".mod.bypasscooldowns"

BONNe avatar Jan 11 '19 15:01 BONNe

It's been opened for quite some time. Is it still needed?

Poslovitch avatar Mar 20 '20 09:03 Poslovitch

Yes, but I am not sure if you will agree with implementing it. Because there are some addons that use global permission from BentoBox. (f.e. modbypass)

Implementing this will require to review all permissions in all non-gamemode addons.

BONNe avatar Mar 20 '20 10:03 BONNe