BentoBox icon indicating copy to clipboard operation
BentoBox copied to clipboard

Add Minecraft 1.21 New Flags

Open huguyt opened this issue 1 year ago • 5 comments

Is your feature request related to a problem?

With the update of Minecraft 1.21, many new items have been added to the game, so new flags are needed to set their permissions.

Describe the solution you'd like.

  • [ ] Crafter There is currently no flag to protect Crafter from being opened by players without permission, Players without permission can even disable a slot by clicking on an empty slot.

  • [x] Wind Charge

  1. Wind Charge can be fired by the player's right click, There is no flag to protect the player from being ejected by Wind Charge. If a visitor uses Wind Charge on an AFK player, and the AFK player is at the edge of the island, the player will be ejected into the void.
  2. Wind Charge can trigger buttons, levers, non-iron doors, trapdoors and fence gates to toggle their block state, extinguish lit candles, and swing bells. In addition, you can also trigger redstone signals by passing through Wooden Pressure Plate, Tripwire, and firing Wind charge at the target to trigger redstone signals. In Bentobox, buttons, levers, non-iron doors and trapdoors, fence gates, lit candles, and swing bells cannot be triggered by Wind Charge.Among Wooden Pressure Plate, Tripwire, and Target, only Wooden Pressure Plate can be protected by the PRESSURE_PLATE flag, The other two do not have any flag to protect them. (Maybe add 2 flags for Tripwire and Target? In vanilla they can be triggered not only by Wind charge, but also by projectiles or entities like arrows, snowballs, thrown tridents, etc.)
  3. When the island owner and the visitor are in the same location, the Wind charge attack from Breeze will not only knock the island owner away, but also the visitor.
  • [x] Trial Spawner
  1. When the SPAWN_EGGS flag is enabled and the SPAWNER_SPAWN_EGGS flag is disabled, the Trial Spawner cannot be protected from being altered by players without permission (such as visitors) (Maybe add TRIAL_SPAWNER_SPAWN_EGGS flag for Trial Spawner.)
  2. The ANIMAL_SPAWNERS_SPAWN and MONSTER_SPAWNERS_SPAWN flags do not prevent Trial Spawner from spawning animals or monsters. (Maybe add ANIMAL_TRIAL_SPAWNERS_SPAWN and MONSTER_TRIAL_SPAWNERS_SPAWN flags for Trial Spawner.)
  • [ ] Vault & Ominous Vault There is no flag protecting the Vault or Ominous Vault from player interaction. Visitors can use Trial Key or Ominous Trial Key to interact with Vault or Ominous Vault

  • [ ] Decorated Pot There is no flag to protect the Decorated Pot from being destroyed by projectiles (such as player arrows, tridents, and arrows fired from a dispenser)

  • [ ] About Honeycomb(I know this is not the content of 1.21) PLACE_BLOCKS flag can protect copper blocks from Honeycomb Waxing, However, the player will still receive the [Wax On] advancement, But the player did not consume Honeycomb. Similarly, using an axe on a waxed block of copper, although the wax is not removed, the player still gains advancement [Wax Off]. I hope there is a flag to add a Waxing and remove wax to the honey comb. The PLACE_BLOCKS flag does prevent both of these events, but I'd like to have a separate flag to control Honeycomb. By the way, Honeycomb can also interact with sign to prevent the text above from being changed.

  • [ ] About Bad Omen buff In Minecraft 1.21, the Bad Omen buff was changed. Players need to use the Ominous Bottle to get the Bad Omen buff for a certain period of time. I hope there is a flag that can set whether to trigger the raid for each island individually.(This flag should be higher than VISITOR_TRIGGER_RAID permissions) If VISITOR_TRIGGER_RAID is disabled, when a visitor visits a Villager trading hall island in 1.21, the bad omen buff will turn into a 30-second Raid Omen, and then the buff will disappear and the raid will not be triggered. I wonder if there is a way to prevent the bad omen buff from turning into a Raid Omen buff, otherwise the visitor will lose the bad omen buff. If a visitor carries a Bad Omen Buff to an island with a trial_spawner, when approaching the Trail Spawner, the Bad Omen Buff on the visitor will be converted into a Trial Omen buff. Same as above. I wonder if there is a way to prevent the Bad Omen buff from converting into Raid Omen or Trial Omen.

Describe alternatives you've considered.

Not considered yet.

Agreements

  • [X] I have searched for and ensured there isn't already an open issue regarding this.
  • [X] I have ensured the feature I'm requesting isn't already in the latest supported BentoBox build or Addons.

Other

That's all I can think of for now. It's a bit long and messy, and I used Google Translate. I'm sorry it's difficult for you to read.

huguyt avatar Jul 04 '24 11:07 huguyt

Thank you! Great translation BTW, no mistakes at all.

I'll work on these.

tastybento avatar Jul 05 '24 18:07 tastybento

Thank you for your hard work, you are the best developer I have ever met.

huguyt avatar Jul 06 '24 13:07 huguyt

Some of these have been done and merged into the SNAPSHOT.

tastybento avatar Jul 17 '24 00:07 tastybento

Note to self for Bad Omen:

A Bad Omen flag could be used to allow different ranks to trigger raids

  • https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/raid/RaidTriggerEvent.html would be the event to allow or deny
  • There doesn't seem to be any events around Bad Omens triggering Trial spawners to become ominous so that looks like it cannot be managed.

tastybento avatar Jul 17 '24 00:07 tastybento

Note: currently it seems that decorative pots break even if the BreakBlocksEvent is cancelled. I think this may be a Spigot/Bukkit bug, but I need to gather more evidence. The event is fired and correctly canceled but the pot still shatters...

tastybento avatar Jul 17 '24 00:07 tastybento