BentoBox icon indicating copy to clipboard operation
BentoBox copied to clipboard

Blueprint schematics paste and sand falling

Open ZzSnkeX opened this issue 1 year ago • 13 comments

Expected behavior

Loading the schematics correctly, able to see the blocks and sand floating when creating a new island

Observed/Actual behavior

When loading and then pasting blueprints the blocks are not visible, if I disconnect and join again I'm able to see it. Sand that floats when creating a schematic, falls after pasting it or when creating a new island. This issue never happened in back versions. I'm currently using 1.20.4 and bugs showed up

Steps/models to reproduce

Using /bsb bp load ,and pasting the blueprint.

BentoBox version

[02:55:41 INFO]: PURPUR 1.20.4 [02:55:41 INFO]: BentoBox :2.0.0 [02:55:41 INFO]: BSkyBlock 1.17.1 (ENABLED)

Plugin list

No response

Other

No response

ZzSnkeX avatar Feb 23 '24 00:02 ZzSnkeX

This is because the blocks are being pasted using NMS to enable speed. I think maybe for the Blueprint admin command that could be changed. Nothing has changed with the code for a long time so this is not a new issue. Anyway I can look at it.

tastybento avatar Feb 23 '24 04:02 tastybento

Tho, when I'm creating a new island with a custom island I can't respawn in my island. I get teleported to the spawn. The rest of the commands work as expected, but the island respawn and the blueprints are the main problem in 1.20.4. When I was using 1.20.2 didn't had this issue, especially with the sand falling

ZzSnkeX avatar Feb 23 '24 08:02 ZzSnkeX

as much as this pains me, BSkyBlock seems to use way more ram in 1.20.4, Island-Respawn flag is bugged, on the default island it doesnt work properly, player gets teleported where the sign is, even if i set another location to spawn with /is sethome, and in the custom blueprint doesnt work. I created different servers with different version to see, and yeah i have to say that BSkyBlock is not working as expected in 1.20.4 following the issues i mentioned. so please fix this asap

ZzSnkeX avatar Feb 23 '24 13:02 ZzSnkeX

I'd like to break these down one by one and clarify:

as much as this pains me, BSkyBlock seems to use way more ram in 1.20.4,

This may just be 1.20.4. What was your previous version that are you comparing to?

Island-Respawn flag is bugged, on the default island it doesnt work properly, player gets teleported where the sign is, even if i set another location to spawn with /is sethome

I can check into this.

and in the custom blueprint doesnt work.

Can you clarify? Is this the original issue you reported where the locks do not appear when pasted?

I created different servers with different version to see, and yeah i have to say that BSkyBlock is not working as expected in 1.20.4 following the issues i mentioned.

Please share which versions you used and with which versions of BentoBox. It will help me understand what you are comparing.

so please fix this asap

Yes. Please share more info.

tastybento avatar Feb 23 '24 15:02 tastybento

Hello, and yeah sorry for not providing more info, as well as the issue with island respawn that i discovered this morning.

This may just be 1.20.4. What was your previous version that are you comparing to?

[18:03:49 INFO]: BentoBox version: 1.24.1 [18:03:49 INFO]: BSkyBlock 1.16.1 (ENABLED) These are the previous versions for what i was using before upgrading. But as you said it can be purpur 1.20.4 related, figuring out right not

Can you clarify? Is this the original issue you reported where the locks do not appear when pasted?

The blocks doesn't show up when pasted, but i used FAWE to create a schematic then saving it into bentobox with /bsb bp save . If if put the [spawn_here] sign in the blueprint the player respawns were the sign is, overriding the /is sethome, causing players to fall in void if they destroyed the blocks underneath Not really the original issue, more a part of it that i consider is important.. discovered this morning.

Please share which versions you used and with which versions of BentoBox. It will help me understand what you are comparing.

I did several tests on Purpur 1.20.2 with Bentobox version 1.24.1 BSkyBlock 1.16.1, as well as the latest Bentobox version 2.0.0 and BSkyBlock 1.17.1, , then changed to Purpur 1.20.4 in order to find the issue

Yes. Please share more info.

As a matter of fact i will update soon or later to the latest purpur release, maybe the ram usage is because of this, not blaming BentoBox/BSkyBlock for this but may or not be the cause

Thanks for the response, if you need more info or something wasn't clear let me know in order to help you

ZzSnkeX avatar Feb 23 '24 16:02 ZzSnkeX

Thanks. And what version of BentoBox are you using? The latest 2.1.0-SNAPSHOT would be best right now.

tastybento avatar Feb 23 '24 17:02 tastybento

Im using 2.0.0, i dont mind if i have to upgrade but im aware i have to reconfig the file

ZzSnkeX avatar Feb 23 '24 17:02 ZzSnkeX

Upgraded to 2.1.0 the issues are still there as expected, when something changes please let me know

ZzSnkeX avatar Feb 23 '24 17:02 ZzSnkeX

The island respawn flag is operating correctly and this code hasn't changed for a few years - it does teleport people to the spawn point of the island that was set by the original spawn-here sign. I do agree that this is probably not the best location to put people because it may no longer be safe. I'll see what alternatives there are.

The pasting of blocks is now done using Bukkit if you use the Admin blueprint paste command or if the player is sufficiently close to where the new island will be pasted (this was an issue with AcidIsland where the island distance was low).

tastybento avatar Feb 24 '24 23:02 tastybento

If the [spawn-here] sign is not there the players will teleport to the spawn on death making the island respawn flag useless

ZzSnkeX avatar Feb 24 '24 23:02 ZzSnkeX

Yes, I see that. I've changed it to be the home position of the island. I'd appreciate your feedback.

tastybento avatar Feb 25 '24 00:02 tastybento

I'd appreciate your feedback.

Thanks for fast support really appreciate it. It's perfect if the respawn is on the home position. When the changes are done and i can install the new snapshot please tell me

ZzSnkeX avatar Feb 25 '24 00:02 ZzSnkeX

Yes, it should be done now. You should be able to download the snapshot from the CI server.

tastybento avatar Feb 25 '24 02:02 tastybento

https://ci.codemc.io/job/BentoBoxWorld/job/BSkyBlock/ If you mean here, it's not there. The latest is the version i currently use 1.17.1

ZzSnkeX avatar Feb 25 '24 10:02 ZzSnkeX

https://ci.codemc.io/job/BentoBoxWorld/job/BSkyBlock/ If you mean here, it's not there. The latest is the version i currently use 1.17.1

You need BentoBox snapshot, not bskyblock ;)

BONNe avatar Feb 25 '24 11:02 BONNe

The blueprint seems to work properly but the island-respawn it's not working, still teleport me to the spawn

ZzSnkeX avatar Feb 25 '24 12:02 ZzSnkeX

and the sand falls when a player creates a island

2024-02-25_14 21 46

ZzSnkeX avatar Feb 25 '24 12:02 ZzSnkeX

Hmm, works for me. Do you have anything else that could be affecting the respawn point?

https://github.com/BentoBoxWorld/BentoBox/assets/4407265/a4b73d81-66b0-4b1a-945d-6aced3102896

In regards to an island made of sand - if there is nothing under the sand, then the sand will fall if there's a physics trigger, which could be as simple as something being attached to a nearby block. If you don't want the sand to fall try putting sandstone under it.

tastybento avatar Feb 25 '24 16:02 tastybento

Here's a video of me setting the home and then respawning at the home position: https://github.com/BentoBoxWorld/BentoBox/assets/4407265/587939e5-5d15-4920-982f-0b6ad750d0c6

tastybento avatar Feb 25 '24 16:02 tastybento

did the same, restarted the island and same i dont get teleported to the island

ZzSnkeX avatar Feb 25 '24 16:02 ZzSnkeX

https://youtu.be/jL4k9htWxAs Island Respawn flag is activated btw

ZzSnkeX avatar Feb 25 '24 16:02 ZzSnkeX

Hmm what other plugins to you have? There must be something overriding the respawn point. I could add some debug but if you have a test server it would be better to try with just Bentobox and then add plugins until it doesn't work.

tastybento avatar Feb 25 '24 20:02 tastybento

My bad it was my plugin that had high priority and was overriding other plugins I think that's it, thanks for the help @tastybento 😄

ZzSnkeX avatar Feb 25 '24 21:02 ZzSnkeX