numbro icon indicating copy to clipboard operation
numbro copied to clipboard

Bytes formatter doesn't respect space separation

Open orangesoup opened this issue 7 years ago • 5 comments

Using 0.00b and 0.00 b gives the same output (notice the space), no space separation with the 2nd one. The formatter is using state.currentAbbreviations(), but that doesn't contain the spaced parameter (and I don't think you can actually set it.) - it works in tests, however.

Using let options = Object.assign({}, defaultOptions, providedFormat); with options.spaceSeparated makes it work.

Sadly I don't have time to create a PR, but I hope I could help to get it fixed soon.

orangesoup avatar Jan 24 '18 18:01 orangesoup

thanks, I'll have a look asap

BenjaminVanRyseghem avatar Jan 25 '18 07:01 BenjaminVanRyseghem

This bug is also visible in the documentation of the v2 API: image

imphil avatar May 04 '18 14:05 imphil

got the same issue

kovpack avatar Jun 15 '18 18:06 kovpack

got the same issue

kruthoff avatar Apr 05 '19 13:04 kruthoff

Assuming this is now fixed with #411

jonyeezs avatar Jul 16 '20 01:07 jonyeezs