Benjamin Bossan

I wanted to create a single issue that collects TODOs around the [LLM feature](https://skorch.readthedocs.io/en/stable/user/LLM.html#using-language-models-as-zero-and-few-shot-classifiers) that was added recently, so that everything is in one place. - [ ] Have a...

Nets using accelerate cannot be pickled

1

See comments and potential solutions discussed [here](https://github.com/skorch-dev/skorch/pull/896#issue-1387870923).

Right now, when using `AccelerateMixin`, the instantiated `Accelerator` instance needs to be passed: ```python accelerator = Accelerator(...) net = AcceleratedNet( MyModule, accelerator=accelerator, ) net.fit(X, y) ``` This new feature should...

Add persistence tests using "malicious" skops files

1

We designed the skops persistence format with the intent of being safe against maliciously crafted skops files. Right now, however, there are not tests that explicitly check that loading these...

Cache model loading in model card

17

Follow up to #96 and #205. The `_load_model` function https://github.com/skops-dev/skops/blob/30ddea7015ac67df3f950da88f32fb035f9332d2/skops/card/_model_card.py#L168-L205 is currently called each time when the `model` of a card is accessed, e.g. when `repr` is called. When the...

Persistence tests fail for LogisticRegression et al. with multiclass classification

7

Right now, when testing persistence of classifiers, we create a binary classification task, and the classifiers all pass. However, when switching to a multiclass classification task, `LogisticRegression` and related estimators...

This was discussed [here](https://github.com/skops-dev/skops/pull/203#discussion_r1044497275), I'll copy the points over (with slight modification): We have a tricky situation in our `Card` class where there can be multiple sources of truth for...

CLI for inspection, and conversion to skops format, of sklearn pickle files

8

It would be useful for skops to provide a CLI that allows to find the untrusted types in an sklearn pickle file, and to convert it to the skops format....

Disabling LoRA with compiled models

2

In PEFT, we've encountered a [bunch of issues](https://github.com/huggingface/peft/actions/runs/8649232169/job/23714965806) with LoRA when using compiled models. I was curious how torchtune solves these issues, so I checked one of them, namely disabling...

Questions and suggestions

1

Hey Miguel, Great work, I think this could be very useful for many people. I have a question: "Unit test" for me implies that this is part of a CI...