Benjamin Bossan
Benjamin Bossan
> Could you determine what is the problem of `doc-builder style src/peft tests docs/source --max_len 119 --check_only` Where did you see that? The code quality check only spits out this:...
> I can take this up and make necessary changes if you are short on time. We can aim to get this PR merged this week, let me know if...
I see. Sure, please go ahead. As you probably can't push on top of this PR, feel free to create a new one. If we don't hear back from moghadas76...
Thanks for the pointer. Indeed, I had a look at this earlier today. IIUC, this works by freezing all the attention layer weights and only unfreezing a random subset of...
> you can almost use the code in their repo as is Yes, I expected as much. We could think about adding this to PEFT (with proper reference to the...
@alexrs Thanks a lot for reviving the feature and updating it so quickly. LMK when you think it's ready for review. @Abdullah-kwl If you could give this a try, that...
Thanks for the PR. For me to be able to review it, could you provide an example of how it should be used?
It looks like empty weights were stored when you saved your checkpoint after DeepSpeed training. Probably if you check the size if the file, you'll find it to be smaller...
Could you check if using this when saving the model resolves the issue? https://github.com/huggingface/peft/issues/2071#issuecomment-2358624041
Thanks a lot for this PR. > can add unit tests if someone gives pointers to similar ones to extend We don't really have a single place where we test...