Benjamin Bossan

Hmm, I'm ambivalent about this change. I totally see how it can be useful in notebooks. The way it's rendered in the docs was very confusing to me though. Apart...

> well, sphinx-gallery only understands `_repr_html_` and not `_repr_markdown_`, so removing `_repr_html_` would make the documentation look like before. So do we want to go with this first? I.e. only...

That sounds like a big expansion of scope for skops, since, as you mentioned, there are so many options out there. I have used only a handful, so making a...

> this is being done with transformers already Can you give a link? > but I'm also in favor of a standalone doc for REST or gRPC endpoint Yeah, we...

Maybe we could add a utility function to `skops.io` so that the conversion can also be called from Python, but apart from that, it should be really straightforward. Probably for...

Yes, it involves loading the pickled object. That's a good point. So the help of those commands should emphasize that this will happen and what it implies.

Yes, it should be framed as "unknown types", not "untrusted".

Thanks for providing this PR. Indeed, as of now, we don't have any special provision for LoRA to deal with fused QKV layers (or any fused layers). For some models...

So I'm assuming that you are training with DDP. DDP requires that all model parameters that require gradients participate in the loss calculation. For some reason, it appears that the...

Let me know when this is ready for review. Also, please run `make style` on the code.