Benjamin Bossan

Results 584 comments of Benjamin Bossan

> if you have a minute could you rerun the CI? Sure, but feel free to ignore those "Error: Codecov: Failed to properly upload" messages. For some reason, those errors...

> I just wanted to check Codecov was actually happy now, the MethodType return not getting tested was making it upset For sure, but you can take any of the...

@E-Aho Excellent, thanks, really great job. Will you be working on the deduplication issue?

To test the changes, I first created a PR containing the word "inference" and indeed all tests ran: ![Screenshot from 2022-09-21 12-46-01](https://user-images.githubusercontent.com/6229650/191485967-bb19437e-7746-4c87-9936-dfd9ed11849a.png) After that, I renamed the title to use...

> I would go with commit message rather than PR title. For some commits we might want to test and for some we might skip. If we forget the tag...

Okay, then let's proceed like this. What is the "right" way to get the commit message? I found `github.event.head_commit.message` but couldn't find any use in sklearn, so I assume there...

@adrinjalali So it seems not to work correctly. First try, `inference-pytest-full` was skipped and `inference-pytest-partial` ran, as expected: ![Screenshot from 2022-09-29 15-13-39](https://user-images.githubusercontent.com/6229650/193050855-bd28e5b6-bd0e-437e-aeb2-a8326315ae48.png) Second try, after an empty commit containing "[CI...

> Your two new workflows have the same name Good catch, I tried to have different names everywhere but missed the top level name :/ Unfortunately, this still doesn't work....

@adrinjalali Still the same issue, "full" never runs and "partial" always runs. So nothing changed, which is not too surprising, as > When you use expressions in an if conditional,...

> At this point I'd suggest creating a new repo on GH and testing things there maybe? Just in case other things are interacting in a weird way with one...