Benjamin Bossan

Results 1181 comments of Benjamin Bossan

Thanks for the updates @Zeju1997 could you please run `make style`?

@Zeju1997 gentle reminder about this PR.

This still did not resolve the issue. Could you please check your ruff version? CI is using `ruff-0.6.7`.

Hmm, that's strange, it could be that somehow your ruff does not pick up on the settings inside of the `pyproject.toml`. I ran it locally on your branch and this...

> I have manually updated the diff you posted. Just in case you didn't know, you can save the diff in a patch file and apply it with `git`.

Your latest change angered the linter again because you removed some type imports that were still being used: ``` ruff check src tests examples docs scripts docker src/peft/tuners/oft/layer.py:119:38: F821 Undefined...

Alright, then let's remove OFT support for mixed models. First change is fairly simple, let's remove it from the mapping here: https://github.com/huggingface/peft/blob/ccc350151f95a9ff95da046bae5671da75eab52f/src/peft/mixed_model.py#L49 Next is a little bit more work, we...

Thanks for the quick action. You missed a few changes still in `test_decoder_models.py`, `test_encoder_decoder_models.py`, and [this line](https://github.com/huggingface/peft/pull/1996/commits/65ce38b833e08893043814725e870e1d2b3ff2ce#diff-d904228fa17421a9b7d8436ef706bd44bcda957e3978fa34624efbdcc8eb191eR187) is missing a space at the end. After this, we have yet to...

> I do get some error with `pytest tests/ -k test_feature_extraction_models` Yeah, I can reproduce that, strange. Maybe it's related to the special layer types that Deberta uses.. I think...

If you set `modules_to_save=["model.layers.0.xxxx"]`, would that solve your problem?