Benjamin Philip

Results 64 comments of Benjamin Philip

@ericmj, and @wojtekmach, please review the `WebAuthRequest` schema and the `WebAuth` context so that I can make improvements (or plan accordingly to work on them). Note: Changes to HexpmWeb is...

@wojtekmach, I have worked on all your reviews pertaining to the context/schema. Can you re-review please?

@wojtekmach and @ericmj, could you review the context please?

@ericmj, > When the CLI authenticates it creates two keys, one key with read only permissions and key with write permissions so that the write key can be password protected....

@ericmj, and @wojtekmach, I am having some difficulty on displaying an error on invalid user code, since the error is a string and not a changeset. I have committed my...

@ericmj, also in the previous comment, I was referring to difficulty in making the user_code submission form.

> > also in the previous comment, I was referring to difficulty in making the user_code submission form. > > I think the way you're doing is great. Is there...

@ericmj, @wojtekmach, I think I have got a working MVP/POC ready. Things I think we need to improve on: - Styling for the verification and success pages - Support for...

Here is a video showing the flow: https://user-images.githubusercontent.com/67545861/145373327-6a8e4bbf-787e-418e-aa97-781814a027b6.mp4 Note: I think the frame rate is a bit slow because I set my `ffmpeg` flags incorrectly when converting to mp4.

Any suggestions/comments @ericmj?