BetterAltay icon indicating copy to clipboard operation
BetterAltay copied to clipboard

Glow SignText

Open efor89 opened this issue 2 years ago • 9 comments

Description

hi can you plz add that we can add glow sign text (not with glow_inc_sak only in code)? its in pmmp5 alredy impliment https://github.com/pmmp/PocketMine-MP/blob/5.0.0-BETA2/src/block/tile/Sign.php

Justification

after the editor was add, the signtext is rly dark and with this we can make it glow. and its rly cool if ba have it.

efor89 avatar May 04 '23 10:05 efor89

Sure

JoseLuisHD avatar May 04 '23 13:05 JoseLuisHD

ty :)

efor89 avatar May 04 '23 14:05 efor89

can u add plz signColorChangeEvent? that we can chancel the color change and glow change for some plugins plz?

efor89 avatar May 07 '23 07:05 efor89

https://github.com/Benedikt05/BetterAltay/commit/02bb5f7366fb95a34854602e6b621d75b7bb9b07

JoseLuisHD avatar May 13 '23 00:05 JoseLuisHD

why close?

efor89 avatar May 15 '23 09:05 efor89

without this changes it works axactly same

efor89 avatar May 16 '23 11:05 efor89

without this changes it works axactly same

didnt josi or something add signtextcolorchangeevent or something?

vp817 avatar May 16 '23 12:05 vp817

yes but if u remove all the code with color and glow from ba it change nothing. if u klick on sign with dye the color change only for you and after rejoin the color is gone. with glow its change to glow if you open editormode with glowincsac and after close the editor the glow is gone.

efor89 avatar May 16 '23 12:05 efor89

so in the moment the event do nothing.

efor89 avatar May 16 '23 12:05 efor89