Benchmark-Models-PEtab icon indicating copy to clipboard operation
Benchmark-Models-PEtab copied to clipboard

Finish Raia model

Open LeonardSchmiester opened this issue 5 years ago • 7 comments

Cannot validate the model with AMICI as the noise model is not supported yet.

LeonardSchmiester avatar Mar 05 '20 09:03 LeonardSchmiester

This was about state-dependent noise, right? (https://github.com/ICB-DCM/AMICI/issues/609)

dweindl avatar Mar 16 '20 17:03 dweindl

It's observable-dependent noise I think

LeonardSchmiester avatar Mar 16 '20 17:03 LeonardSchmiester

@LeonardSchmiester Would you have the PEtab tables around (i.e. at least the data)? I would be interested in using the raw data and would not need the model itself

jvanhoefer avatar Jan 11 '22 20:01 jvanhoefer

Here? https://github.com/Benchmarking-Initiative/Benchmark-Models-PEtab/tree/model_Raia_CancerResearch2011/Benchmark-Models/Raia_CancerResearch2011

dweindl avatar Jan 11 '22 20:01 dweindl

Ah, thank you, did not have a look at all the branches :)

jvanhoefer avatar Jan 12 '22 09:01 jvanhoefer

Cannot validate the model with AMICI as the noise model is not supported yet.

Supported by https://github.com/AMICI-dev/AMICI/pull/1692, in case somebody feels like finishing this one.

dweindl avatar Mar 04 '22 09:03 dweindl

I finished it and also did optimization again, ended up with a different optimum than the one from the matlab BenchmarkCollection but the fit is slightly better for two and worse for one other observable so I left the nominalParameters that correspond to the other BenchmarkCollection.

m-philipps avatar Sep 22 '23 11:09 m-philipps