Benchmark-Models-PEtab icon indicating copy to clipboard operation
Benchmark-Models-PEtab copied to clipboard

Visualization files for all models (list)

Open MerktSimon opened this issue 6 years ago • 9 comments

This issue serves as an overview of which models already have the visualization file. During the work on each model this model's issue should be re-opened. Once all models have one this can be closed.

Models which already have a visualization file:

  • Isensee
  • Chen
  • Fujita
  • Swameye_PNAS2003
  • Boehm
  • Bruno_JExpBio2016
  • Raia_CancerResearch2011

MerktSimon avatar Aug 20 '19 09:08 MerktSimon

Since a lacking visualization file is not a PEtab error, reopening LeonardSchmiester/Benchmark-Models#53 didn't seem to fit. But of course this can be discussed. Also re-opening all models' issues could work but seems a bit confusing

MerktSimon avatar Aug 20 '19 09:08 MerktSimon

Fujita does not actually have a file yet. It only serves as example for no-file visualization in PEtab. Hence I removed it from the list. Thanks @erikadudki for pointing it out.

MerktSimon avatar Nov 28 '19 16:11 MerktSimon

I just added a visualization file for the Chen model.

erikadudki avatar Nov 28 '19 17:11 erikadudki

I will work now on the visualization file for the Fujita model. Fujita visualization file finished!

erikadudki avatar Nov 29 '19 09:11 erikadudki

working now on Boehm

erikadudki avatar Nov 29 '19 10:11 erikadudki

Added visualization file for Swameye_PNAS2003. Plots fit with the plots in the publication.

LaraFuhrmann avatar Feb 06 '20 14:02 LaraFuhrmann

Added visualization file for Bruno_JExpBio2016. Measurements of model1_data3 and model1_data6 seem a bit odd to me, since some measurements are in the range of [0,3] and others in the range of [1000,2500] Edit: change to log10-scale for those measurement values

LaraFuhrmann avatar Feb 07 '20 10:02 LaraFuhrmann

added visualization file for Raia_CancerResearch2011

erikadudki avatar Feb 10 '20 08:02 erikadudki

Would be great if you could also update the YAML files when adding new vis tables (see Bruno for example).

dweindl avatar Feb 10 '20 08:02 dweindl

Can this be merged/consolidated with issue #156?

stephanmg avatar Nov 13 '24 15:11 stephanmg

Can this be merged/consolidated with issue #156?

Yes, thanks for the contributions from everyone so far

dilpath avatar Nov 14 '24 13:11 dilpath