Benchmark-Models-PEtab icon indicating copy to clipboard operation
Benchmark-Models-PEtab copied to clipboard

add new model Liu_IFACPapersOnLine2025

Open m-philipps opened this issue 9 months ago • 0 comments

Checklist for the submission of new PEtab problems

  • [ ] The PEtab problem is based on a model that is peer-reviewed and published
  • [ ] The problem ID is in the format {LAST_NAME_OF_FIRST_AUTHOR}_{ABBREVIATED_JOURNAL_NAME}{YEAR_OF_PUBLICATION} $\to$ We use IFACPapersOnLine instead of the ISO Journal abbreviation due to the - that can not be used in SBML id
  • [x] The problem ID is in the pull request title
  • [x] There is a GitHub issue for this problem: closes #257
    • [x] The problem ID is in the issue title
    • [x] A brief model description (one or two sentences)
    • [x] A brief data description (one or two sentences)
    • [x] The issue and PR are linked to each other
    • [x] Differences between the implementation and the original publication are described
    • [x] Experience of fitting / uncertainty analysis (e.g. optimizer used, hyperparameters, reproducibility of best fit)
    • [x] Source of nominal parameters (e.g.: taken from the original publication, or from your own fitting)
  • [ ] The SBML file
    • [ ] Annotation with reference to the original publication (example)
    • [x] The model ID and model name attributes in the SBML model file match the problem name (example)
  • [ ] PEtab files
    • [x] A "simulated data" measurement table is included, using the nominal parameters
    • [x] A visualization table is included, that can be used with the simulated data to reproduce figures from the original publication
    • [x] The PEtab problem is valid (check with e.g. petablint -vy problem.yaml)
  • [x] The PEtab problem author(s) are assigned to the GitHub issue
  • [ ] The README has been updated with bmp-create-overview --update (requires pip install -e src/python/bmp from the repository root)
    • [ ] The new PEtab problem row in the generated table has the correct reference (and other entries)

This is a draft, waiting for the model to be published.

m-philipps avatar Jan 06 '25 15:01 m-philipps