Benchmark-Models-PEtab icon indicating copy to clipboard operation
Benchmark-Models-PEtab copied to clipboard

Published 20 hours ago • verified publisher icon Benchmarking-Initiative

new format for swameye

Open LoosC opened this issue 7 years ago • 6 comments
trafficstars

LoosC avatar Oct 18 '18 14:10 LoosC

Model parameter 'spline_t_0' neither present in condition table nor in parameter table.

dweindl avatar Mar 11 '19 18:03 dweindl

aaah the spline, need to think about how to treat this one...

LoosC avatar Mar 18 '19 01:03 LoosC

Just saw this... An assignment rule might do the trick, maybe? Dunno if SBML knows something like a spline-function however... Guess almost that "no", as zillions of splines are possible and just defining "some" spline is not well-defined then...

paulstapor avatar May 11 '20 14:05 paulstapor

In the original version of the model from the old repository, it is done via an assignment rule and events. I guess we could just use that one as soon as events are implemented?! ;-)

LeonardSchmiester avatar May 11 '20 15:05 LeonardSchmiester

We can use this one, but I'd actually be happy to use the new spline implementation as soon as this one is finished. That will change the model to some degree (as now Amici will get cubic Hermite splines and originally the model had cubic C2 splines), but also using events instead of splines does so, so I think it's overall fine...

paulstapor avatar Feb 18 '21 09:02 paulstapor

https://github.com/AMICI-dev/AMICI/pull/1515 contains this model. the spline is added there as piecewise. should be easy now to include that in the benchmark collection

dweindl avatar Apr 14 '23 09:04 dweindl