Bence Szalai

Results 77 comments of Bence Szalai

Well, I've never used Lumen myself, so I don't know what are the differences compared to regular Laravel. Maybe if you have shared some of your code and what you...

I'm not fighting either, just saying it is not really a discussion for this forum. Being that said, sure, the refresh token route must be excluded from the auth middleware....

> It will require that new major version number because lcobucci/jwt 4.0 does not support php 7.2 or 7.3, while jwt-auth 1.0 does. I think it is not required. lcobucci/jwt...

I've faced the same issue. It looks like it is because of the check [from row 2938 in script.js](https://github.com/aristath/kirki/blob/develop/controls/js/script.js#L2938): ```javascript if ( _.isUndefined( currentSettings[ row.rowIndex ][ fieldId ] ) )...

Probably, because you client side uses the minified JS. Look for `script.min.js` and try to make the same change on that too.

Looks like it has moved since here: https://github.com/kirki-framework/kirki/blob/develop/packages/kirki-framework/control-repeater/src/assets/scripts/control.js#L736

> `Eloquent\Builder` checks for macros first, and then defers to the internal `Query\Builder` second. That means right now you can define a macro on the Eloquent builder that supersedes the...

Only 3 of these commits relates directly to this PR: * 5bd373f * 6369663 * fffa3cb

Thinking about this, what do you think the minimum viable implementation would be? Do you mean just to split `WP_Background_Process` into few classes, each implementing one of these: - a...

## `getBindings()` vs. custom resolution method I agree that this is a much simplified version, but please note that I've added this way of binding to cover the simple cases....