FastCraft icon indicating copy to clipboard operation
FastCraft copied to clipboard

enable folia support.

Open alexvermaning0 opened this issue 2 years ago • 3 comments

adding this to the plugin.yml enables folia support.

i have done some testing and the plugin works on folia just fine. image

you can also just do it manually.

alexvermaning0 avatar Jun 24 '23 12:06 alexvermaning0

I doubt that's all you'd need to do image image

Atticuss26 avatar Mar 15 '24 17:03 Atticuss26

Sorry for the late reply! I missed this issue when it was created. I'd be a little skeptical that FastCraft would work out of the box multi-threaded. I'm not familiar with Folia or how it works, but I have given multi-threading a shot with FastCraft in the past and ran into trouble. Mainly because crafting items interacts with the world (recipes/permissions differing by world, player stats, etc.), so instead of calculating available items to be crafted on multiple threads, I loaded them gradually doing a certain amount per game tick.

It's been years since I've worked on that code, so things may have changed and I'm definitely rusty, but I'd want more confidence about what Folia does, what needs to be changed, and why other things don't need to (config, player preferences, etc.).

And I suppose more generally, what the impact is of supporting Folia vs. not. (small/big performance increase, not being able to use FastCraft at all on Folia servers without support, is there any maintenance burden when developing FastCraft, etc.)

I'm definitely not informed enough to know these myself, but it's definitely up for discussion :)

BenWoodworth avatar Mar 18 '24 01:03 BenWoodworth

i have re-done the test with folia. it needs some work. on the newer versions of folia the plugin has issues loading. but on a older version of folia it works pretty well. there is an issue with the wooden planks blocks only listing 2 out of 3 wood types.

here is it running on an older version of folia: https://github.com/BenWoodworth/FastCraft/assets/17603899/daa0f5f7-49b2-48d0-a73b-6e9f02d35bf0

error log of fastcraft on newer folia: https://pastebin.com/Myxbphbe

alexvermaning0 avatar Mar 25 '24 11:03 alexvermaning0