Benjamin Elder

Results 2596 comments of Benjamin Elder

I'm in favor of this.

I don't think we should worry about windows / Mac for now. We're supporting 2.X in kind 0.9

I expect revamped image loading to land in v0.11.0 (just started the cycle for that), I'm not sure we should block on windows / mac support. We also have some...

/remove-lifecycle rotten I'm not sure if we want to establish a full blown KEP just yet, versus starting with some experiments for specific efforts. First up declarative validation, but also...

I think to start we don't need e2e to check it (the controversial part), we can start by making sure we capture the data and scan CI for any results....

... scanning the PR bucket for files to check is _slow_, it can be fast when you have a longer prefix (works for periodic jobs) but the way PRs are...

I think I have a workable middle ground that makes this selectable with the usual test filtering but still run after all the tests: https://github.com/kubernetes/kubernetes/pull/133394 I also don't know that...

Yeah, I thought about it some more since my last comment and I plan to write one to make sure we formalize the plan and what we think is reasonable....

Thanks for the draft! I don't think this is quite what I was expecting 😅 , commented more above

This plugin isn't being used by Kubernetes at all. FYI as a third party user: https://github.com/kubernetes-sigs/prow/issues/113