Ben Souchet

Results 63 comments of Ben Souchet

@Snailedlt Yep its looks good to me. And I agree with @kilian-paquier this file: https://github.com/devicons/devicon/blob/develop/.github/PULL_REQUEST_TEMPLATE/new_icon.md could be also edited like: from ```markdown A new object is added in the devicon.json...

@Snailedlt In the [Files Changed section](https://github.com/devicons/devicon/pull/1332/files) I don't see the modification of the [new_icon.md file](https://github.com/devicons/devicon/blob/develop/.github/PULL_REQUEST_TEMPLATE/new_icon.md), is it normal ?

Hi :wave:, I checked, and on my side I approve the changes :+1:

Since there is multiple logos / icons on the [Ressource page](https://nodered.org/about/resources/) of the Node-RED project, I asked [here](https://discourse.nodered.org/t/what-is-the-official-logo-icon-of-the-project/65692) what is the official logo to use.

Hi, according to the guideline : https://github.com/devicons/devicon/wiki/What-Icons-Do-We-Accept%3F The affinity softwares does not enter in one of the category for devicon, since this is not related to code / dev.

It will take more explanations / arguments to convince me on that.

In my opinion the easiest way for now would be to create a PR to lint the file, and check if users place correctly the new entry, and finally add...

@Snailedlt I just created this PR https://github.com/devicons/devicon/pull/1344 😊

In the PR I mention in my prev comment, I talk about [spectral](https://github.com/stoplightio/spectral), a JSON linter that can be useful, and can maybe be linked in this project when a...