BenPru
Using ID_Soll_BWS_akt for hot water target temperature
Using ID_Soll_BWS_akt for hot water target temperature See https://github.com/BenPru/luxtronik/issues/280
@blue-bean Is this working for all Firmware Versions? Please provide a changelog Text.
For me it is not working with V3.90.2-12457 firmware and also. not for 3.90.3
For me it is not working with V3.90.2-12457 firmware and also. not for 3.90.3
Which version of HA and which version of this integration? How did you the changes described in my commit?
I refer to my comment on Oct 22, 2024 in #280:
"So with FW3.79, still ID_Einst_BWS_akt needs to be used (as does the 2024.10.5-Beta luxtronik integration) This means any change in the integration to use ID_Soll_BWS_akt instead of the currently used ID_Einst_BWS_akt should be firmware version dependant (>= .90)"
In your commit, I see that you simply change the target parameter to ID_Soll_BWS_akt where it currently is ID_Einst_BWS_akt. I do not see the target parameter being a firmware dependant? That means this PR will break the integration for users who are not on FW 3.90.x !
Fixing the problem for some users and at the same time breaking it for others is not the way forward. So please implement a FW dependant setting, as that apparently is what is needed now since the Luxtronik FW versions require different target parameters.
OK as far as I understand, the switch in the naming ist due to Luxtronik. Therefore @blue-bean could we keep the old entity with the old name but intorduce a new entity with the right refference from version xxx_90?
@Codectory used this for the implementation of the power limitation min_firmware_version_minor=FirmwareVersionMinor.minor_90,
Could we make the variable based on the running/installed firmware version? This way it's not broken for users that didn't update their firmware and it doesn't break when you update your firmware 🤓?
I'm currently at exactly that problem. I did update firmware and I can't set BW temp...
@rhammen, @BenPru : could you help to make this version dependent? It would be nice to get this bugfix into a new release.
Alternatively, we can choose to drop support for the lower firmware versions for beta release for the sake of progress.
This may be a duplicate of https://github.com/BenPru/luxtronik/pull/357
@blue-bean : it doesn't seem to work in combinatie with other changes in the latest developer release. Can you have a look at it? It might be a mistake on my side. Can you check?