BenPru
Added additional sensors
* Added additional sensors for flow in temperatur and target of circuit 2 and 3
* Added counter of additional heat generator2
Related to: https://github.com/BenPru/luxtronik/issues/285
Example of new sensors:
@BenPru Can you please merge this commits?
@blue-bean I marked the dev branch as main branch in my repo. If you want to use those sensors, you can add my repo as a custom repository to HACS in the meantime.
@toggm I've tested your files but with this changes i've the effect that every second start of HA there are some sensors missing (only every second restart - after next restart all sensors working fine). Very strange
@toggm I've tested your files but with this changes i've the effect that every second start of HA there are some sensors missing (only every second restart - after next restart all sensors working fine). Very strange
@blue-bean I've seen similar behaviour, not sure if it's really related to my chances as I see an exception in a different place. Seems to be a timing issue. But I'll have a look.
@toggm Can you push your changes as pull requests to my fork https://github.com/blue-bean/luxtronik_ait ? I don't know another way to import your pull requests in my local BenPru-repository using Github-Desktop.
@blue-bean you could either fork my repository of pull my remote branch. https://stackoverflow.com/questions/1709177/pull-a-certain-branch-from-the-remote-server
The changes are in the feature/flow_in_circuit_temperatures branch.
@blue-bean I'm missing the following fix which was merged back to main after I forked the repo: https://github.com/BenPru/luxtronik/commit/012baaf96ba86f9f9c06c69c6409f0703af8d394
I'm now going to rebase.
@blue-bean Rebasing has fixed the error. @BenPru what about reviewing/merging this MR?
I've merged this changes locally into the latest main branch (2024.11.15) and can confirm that all changes work fine.
@toggm Please provide a release text to describe the breaking changes. 🙏 Sorry for the delay. Many things around me atm.
@toggm Please provide a release text to describe the breaking changes. 🙏 Sorry for the delay. Many things around me atm.
@BenPru Thanks for answering. Should I post the release notes here or where do you expect me to document those changes?
@toggm Please provide a release text to describe the breaking changes. 🙏 Sorry for the delay. Many things around me atm.
@BenPru I've created now a short description about the renaming of the sensors and the newly introduced sensors, hope this will help to be able to merge this PR.
Release notes
This release fixes the naming of the heating circuit sensors. Before, circuit-1 sensors where in fact sensors of the main heating circuit. Circuit-2 sensors where point to mixing circuit-1, circuit-3 where pointing to mixing circuit-3. Mixing circuit-2 was missing at all.
Harmonize naming of circuit sensor names
The following renaming was applied:
- Main circuit sensors now start without
circuitprefix to distinguish them between the mixing circuits - Mixing circuit sensors now start with
circuit<Number>prefixes - Circuit-2 sensors names where renamed to circuit-1 sensors names
- Naming of Circuit-3 sensors was just harmonized to the same pattern
All Renaming where described in the following issue: https://github.com/BenPru/luxtronik/issues/291
The sensors where renamed as follow:
| Entity name before | Renamed to |
|---|---|
| sensor.<identity_prefix>_heating_circuit_curve1_temperature | sensor.<identity_prefix>_heating_curve_end_temperature |
| sensor.<identity_prefix>_heating_circuit_curve2_temperature | sensor.<identity_prefix>_heating_curve_parallel_shift_temperature |
| sensor.<identity_prefix>_heating_circuit_curve_night_temperature | sensor.<identity_prefix>_heating_curve_night_temperature |
| sensor.<identity_prefix>_heating_circuit2_curve1_temperature | sensor.<identity_prefix>_heating_curve_circuit1_end_temperature |
| sensor.<identity_prefix>_heating_circuit2_curve2_temperature | sensor.<identity_prefix>_heating_curve_circuit1_parallel_shift_temperature |
| sensor.<identity_prefix>_heating_circuit2_curve_night_temperature | sensor.<identity_prefix>_heating_curve_circuit1_night_temperature |
| sensor.<identity_prefix>_heating_circuit3_curve1_temperature | sensor.<identity_prefix>_heating_curve_circuit3_end_temperature |
| sensor.<identity_prefix>_heating_circuit3_curve2_temperature | sensor.<identity_prefix>_heating_curve_circuit3_parallel_shift_temperature |
| sensor.<identity_prefix>_heating_circuit3_curve_night_temperature | sensor.<identity_prefix>_heating_curve_circuit3_night_temperature |
The history will update itself. All other custom integrations (dashboard, automations, helpers, templates, ...) need to be migrated manually.
Introducing new sensors
The following sensors where newly introduced:
| New entity | Description |
|---|---|
| sensor.<identity_prefix>_heating_curve_circuit2_end_temperature | Target end temperature of mixing circuit 2 |
| sensor.<identity_prefix>_heating_curve_circuit2_parallel_shift_temperature | Parallel shift temperature of mixing circuit 2 |
| sensor.<identity_prefix>_heating_curve_circuit2_night_temperature | Night temperature shift of mixing circuit 2 |
| sensor.<identity_prefix>_flow_in_circuit1_temperature | Flow-in temperature of mixing circuit 1 |
| sensor.<identity_prefix>_flow_in_circuit2_temperature | Flow-in temperature of mixing circuit 2 |
| sensor.<identity_prefix>_flow_in_circuit3_temperature | Flow-in temperature of mixing circuit 3 |
| sensor.<identity_prefix>_flow_in_circuit1_target_temperature | Flow-in target temperature of mixing circuit 1 |
| sensor.<identity_prefix>_flow_in_circuit2_target_temperature | Flow-in target temperature of mixing circuit 2 |
| sensor.<identity_prefix>_flow_in_circuit3_target_temperature | Flow-in target temperature of mixing circuit 3 |
| additional_heat_generator2_operation_hours | Heat generator 2 operation hours |
To my knowledge, renaming an entity will only effect new installs. It shouldn't effect existing entities, so this shouldn't be a breaking change.
Is my assumption wrong?
Secondly, I'm always struggling to visualize what the entities mean. @toggm : Do you happen to have a drawing with the sensors on a basic heatpump layout? I can create a nice picture out of it and update the documentation.
@AJediIAm Renaming of an entity is then a breaking change, if you reference the entity in an automation, in a template or in the dashboard those references will point to non-existing entity anymore. Therefore the change is kind of breaking.
Reagarding the drawing I need to check the documentation of my heatpump integration and see if I could enrich it with some of the sensors.
@AJediIAm I have to say that in my opinion the renaming and introduction of @toggm's new sensors is highly intuitive. It is catchy, consistent and congruent across all mixing circuits. I have been using this extension for almost a month now with excellent experience. I particularly missed the ‘xxx_flow_in_circuitx_temperature’ entity in the past, as this differs from the ‘xxx_flow_in_temperature’ entity of the heat pump in a combined storage tank.
