Error when AI attempts to use deployed squad(s)

[mattregul]

Describe the bug AI errors when trying to utilize a manually deployed squad.

What happened

• Player messes with DF while AI is doing its job, sending three squads off to raze a goblin fortress
• Hostiles arrive while the three squads were still away
• AI expected all squads to be home/available
• Military portion of AI errors out (listed below), but AI continues to run manager, farming, and other modules.
  • (Unsure if the other two available squads engaged the hostiles or not)

Expected behavior Add a check of some sort to see if the selected squad is home or away, before trying to assign targets.

Visual reference Listing targets isn't available for away-squads

df-ai debug log opened. version information follows:
Dwarf Fortress 0.44.12
  Windows 64-bit
df-ai 0.44.12-r1-update1-14-g0c6225b2
  code 0c6225b2fa9a12e483b7a513adcc45b98a99a684
DFHack 0.44.12-r1-1-g55d5d477
  library 55d5d4777619e061ba63fc66901dec63ca23d141
  structures 23500e4e9bd1885365d0a2ef1746c321c1dd5094
Assertion failed on population_military.cpp line 983: ui->squads.in_kill_order && !ui->squads.in_kill_list
failed to enter target mode

Assertion failed on population_military.cpp line 985: ui->squads.in_kill_list
failed to enter target list

Assertion failed on population_military.cpp line 983: ui->squads.in_kill_order && !ui->squads.in_kill_list
failed to enter target mode

Assertion failed on population_military.cpp line 985: ui->squads.in_kill_list
failed to enter target list



df-ai debug log opened. version information follows:
Dwarf Fortress 0.44.12
  Windows 64-bit
df-ai 0.44.12-r1-update1-14-g0c6225b2
  code 0c6225b2fa9a12e483b7a513adcc45b98a99a684
DFHack 0.44.12-r1-1-g55d5d477
  library 55d5d4777619e061ba63fc66901dec63ca23d141
  structures 23500e4e9bd1885365d0a2ef1746c321c1dd5094
Assertion failed on population_military.cpp line 983: ui->squads.in_kill_order && !ui->squads.in_kill_list
failed to enter target mode

Assertion failed on population_military.cpp line 985: ui->squads.in_kill_list
failed to enter target list

Assertion failed on population_military.cpp line 983: ui->squads.in_kill_order && !ui->squads.in_kill_list
failed to enter target mode

Assertion failed on population_military.cpp line 985: ui->squads.in_kill_list
failed to enter target list

[lethosor]

This may be related to https://github.com/DFHack/dfhack/issues/1393

[XorOwl]

I have a related error, but not the same. Messing with it and sending out squads makes my AI think that those people no longer live there even though they're only traveling. So it unassigned all of the bedrooms, and reassigned all the squads, causing a segfault crash.