midi2 icon indicating copy to clipboard operation
midi2 copied to clipboard

Adding cargo semver checks

Open seattlelizzard opened this issue 1 year ago • 3 comments

Adding cargo semver checks to Github actions yaml

seattlelizzard avatar Feb 15 '25 12:02 seattlelizzard

Thanks for the PR! 🏅

BenLeadbetter avatar Mar 02 '25 09:03 BenLeadbetter

This patch would have cargo semver checks running on each PR against develop. This would be redundant since the check only makes sense to run on releases - PRs against develop do not tend to involve a cargo version bump, which would make the semver checks useless, if I understand correctly.

One thing we could do is have the checks run only for PRs against main (since these tend to be the release PRs)

BenLeadbetter avatar Mar 02 '25 09:03 BenLeadbetter

BTW, I'm currently working on some automatic release start / finish actions which would also automatically run the checks, but these are still WIP.

BenLeadbetter avatar Mar 02 '25 09:03 BenLeadbetter