bowtie2 icon indicating copy to clipboard operation
bowtie2 copied to clipboard

cmake produces identical bowtie-align-l and bowtie-align-s files

Open OH-AU opened this issue 1 year ago • 4 comments

Using cmake results in bowtie--l and bowtie--s in being identical files. Using the makefile to build the binaries results in different binaries for -l and -s files. Tested in the case of both v2.5.1 and v2.4.4.

OH-AU avatar May 02 '23 01:05 OH-AU

Hello, thank you for reporting this issue.

This has been fixed with the most recent commit to the bug_fixes branch. If you find any additional issues with the CMake script please let us know.

ch4rr0 avatar May 02 '23 18:05 ch4rr0

Thank you for looking and fixing it so quickly. Referring to aefef02 ; using the CMakeFile there for 2.5.1, I get different binary files for bowtie2-align and bowtie2-build, however the binaries for bowtie2-inspect-{s/l} are still identical. Should this be the case?

OH-AU avatar May 03 '23 06:05 OH-AU

Hello,

I pushed a commit to address the issue with bowtie2-inspect-l.

ch4rr0 avatar May 03 '23 16:05 ch4rr0

Thanks again - with the above commit ( eef707a ) all files now result in different binaries. ninja test passes all 5 tests. Should be good to close.

OH-AU avatar May 03 '23 22:05 OH-AU