Nuget Publishing

[xXLAOKOONXx]

Currently the publishing of nuget packages is a manual task reducing the agility and user experience of this wrapper.

"nuget publishing is currenly broken and we'd need someone to take it over." - BenFradet (https://github.com/BenFradet/RiotSharp/issues/684#issuecomment-863869143)

Does this mean someone needs to implement the pipeline or take over the complete process or project? I experimented a bit with nuget and github actions to create a pipeline that on tag/release creation is able to build and publish a nuget package. If this sounds good, I can write an action for RiotSharp. (I would need a nuget key for nuget publishing in the project secrets for the pipe to work, I can give more detailed explaination if this is the way to go.)

[BenFradet]

I experimented a bit with nuget and github actions to create a pipeline that on tag/release creation is able to build and publish a nuget package. If this sounds good, I can write an action for RiotSharp.

This sounds good :+1:

[xXLAOKOONXx]

Short Update:

• I am working on it in my Fork -> quite promising
• I have to build some documentation (incl 'How to set up') and test my implementation.

Due to my match-v5 implementation the tests are outdated and throw errors, therefore I could not include them. To include testing that requires an api key a permanent key might be stored in repository secrets, but this is another topic.

[xXLAOKOONXx]

There is the option to push the build nuget package onto github as well. It will appear in the 'packages' section (see in bot right of screenshot)

[xXLAOKOONXx]

Implementation finished. please check the markdown file and add nuget api key to secrets.

[xXLAOKOONXx]

Implementation done and merged. @BenFradet Can you try a release to check whther is working accordingly? There should be two new commits regarding match v5 not included in 5.0.0-alpha.

[BenFradet]

yes I'll try on Monday I think :+1:

[xXLAOKOONXx]

Want to reask about trying setting a new Release. :)

[BenFradet]

oops sorry, I'm on holidays starting next week. I should have more time then :+1:

[bugproof]

@xXLaokoonXx I switched to https://github.com/MingweiSamuel/Camille The DX is much better and the API in overall seems more consistent and feels nicer. Doesn't throw exceptions for 404 errors but returns null instead (better performance wise) and many other advantages over this library. The author also maintains Rust's version which is nice.

[xXLAOKOONXx]

As you can see in #706 the installation of riotsharp is a barrier for using the framework.

If you have any questions or my documentation is not descriptive enough hit me up.