RiotSharp icon indicating copy to clipboard operation
RiotSharp copied to clipboard

Published 20 hours ago • verified publisher icon BenFradet

Added TFT Endpoints : Issue#640

Open nolanbradshaw opened this issue 5 years ago • 7 comments

Added the endpoints needed for tft. Endpoints were added for League, Match, and Summoner. Also, added unit tests for the endpoints (minus match endpoints)

nolanbradshaw avatar Jan 29 '20 18:01 nolanbradshaw

Thank you for you first contribution! The code looks good 👍 I have a change request regarding the structure of the code:

Please create new endpoints for the added methods, i.e. add:

  • TftLeagueEndpint
  • TftMatchEndpint
  • TftSummonerEndpint

with the corresponding interfaces, so that the endpoint classes match the API sections in Riot's documentation.

JanOuborny avatar Feb 01 '20 01:02 JanOuborny

Sounds good. I'll have those changes made pushed tomorrow morning. If you have any other issues I can work on let me know!

nolanbradshaw avatar Feb 01 '20 20:02 nolanbradshaw

Hello, I'm sorry didn't saw this pull request and worked last few theys on my changes. I hope I added something new 👍

skwiatko avatar Feb 01 '20 20:02 skwiatko

Fixed the issues pointed out by @BenFradet in latest commit.

nolanbradshaw avatar Feb 12 '20 14:02 nolanbradshaw

👍 , did you end up creating a separate issue for the tests you had marked as ignored? Yes just created them, Issue #653!

nolanbradshaw avatar Feb 19 '20 16:02 nolanbradshaw

Hello, is this working? Can I put it on vb.net? Here is giving error (tftmatchendpoint)

fetonin avatar Feb 20 '21 03:02 fetonin

Is there a timeline for merging and deploying these changes? I just about implemented the whole TFT API until I saw it's already in this PR. This would be very useful for a project I'm working on, thanks!

tVoss avatar Oct 16 '23 04:10 tVoss