RiotSharp icon indicating copy to clipboard operation
RiotSharp copied to clipboard

Published 20 hours ago • verified publisher icon BenFradet

LeagueEndpoint update, new properties in championMastery and league

Open skwiatko opened this issue 5 years ago • 3 comments

#621

#Deprecated

  • GetLeaguePositionsAsync

#Added

  • GetLeagueEntriesAsync
  • GetLeagueEntriesBySummonerIdAsync
  • GetGrandMasterLeagueAsync

#Fixed

  • LeaguePosition.cs
  • ChampionMastery.cs

skwiatko avatar May 09 '19 13:05 skwiatko

This kinda makes #622 obsolete

kirides avatar May 09 '19 14:05 kirides

Thanks for your contribution 👍 Unfortunately, we have a merging problem now. I propose that we merge #622 first, because it contains unit tests for the new methods and closer resembles the structure of the API. When it's done please rebase your branch onto develop and then we are going to merge the remaining changes.

JanOuborny avatar May 11 '19 09:05 JanOuborny

Ok, I can also add unit tests and other things.

skwiatko avatar May 11 '19 10:05 skwiatko