#192

Open zweissman opened this issue 4 years ago • 2 comments

Added command line script convert_from_path.py Updated ValueError message for Size not being a tuple or integer. It was missing the format part of the statement and added the actual type that is being passed.

Mar 24 '21 19:03 zweissman

Sorry I am a bit slower to respond these days. I have been working too much.

I like the idea of your PR and the code seems fine as well. I'll test it in the coming days and if it works it should be good to merge.

Mar 31 '21 02:03 Belval

--param_name -> --param-name (snake case in CLI arguments is uncommon - argparse will automatically convert the dest variable names to snake case for you)
help="int: ... -> type=int (rather than putting type names into help, it would make a lot more sense to use the type parameter to actually enforce correct types and ensure useful error messages)

Oct 26 '21 15:10 mara004