TextRecognitionDataGenerator icon indicating copy to clipboard operation
TextRecognitionDataGenerator copied to clipboard

Correct Bidi "fa" and "ar" in texts and file names.

Open hzawary opened this issue 3 years ago • 2 comments

Farsi and Arabic is a right-left languages so we need to write its text in that way and this PR covers some report issues #57 and #161 to fixing and improves it on both texts and filenames.

Also a font file added in "fa" path: trdg/fonts/fa and a example CMD file duo to execute on windows machines.

hzawary avatar Sep 08 '21 09:09 hzawary

Ok, as you wish :)

On Sun, Sep 19, 2021 at 11:16 PM Edouard Belval @.***> wrote:

@.**** requested changes on this pull request.

Please do not add top level scripts to generate data (basic_py_module.py, run_example_windows.cmd). The rest looks good to me.

In .gitignore https://github.com/Belval/TextRecognitionDataGenerator/pull/227#discussion_r711786352 :

@@ -101,3 +101,7 @@ ENV/

.mypy_cache/

.vscode/*

+/.vs

+/out

+/tests

+/trdg/dicts/ar - Copy.txt

Please don't change the .gitignore file.

In run_example_windows.cmd https://github.com/Belval/TextRecognitionDataGenerator/pull/227#discussion_r711786413 :

@@ -0,0 +1 @@

+python trdg\run.py -f 45 -c 20 -w 3 -r -bl 1 -rbl -l "fa" -e "png" --background 2 --name_format 0 --stroke_width 1 --skew_angle 2 -rk --distorsion 3

Please remove this file.

In basic_py_module.py https://github.com/Belval/TextRecognitionDataGenerator/pull/227#discussion_r711786439 :

@@ -0,0 +1,16 @@

+

Please remove this file.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Belval/TextRecognitionDataGenerator/pull/227#pullrequestreview-758176124, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJZTEBTSPVKJWBZX35GVZLUCYVYVANCNFSM5DUIYHDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--


Hashem Zavvari, MA degree, SWE. .NET developer at Hooshkavan Co. Islamic Republic of Iran, Mashhad.

hzawary avatar Sep 21 '21 05:09 hzawary

Delete basic_py_module.py

Delete run_example_windows.cmd

Changed back .gitignore

hzawary avatar Sep 21 '21 05:09 hzawary