Only 1000 unique strings are being generated

[shankar-surepass]

While using GeneratorFromRandom only 1000 random data are generated. While I cheked the source code I could not found any issue with the code. However I had changed the pool of symbols and letter and digit pool are same. Is there is some issue with the python random?

[Belval]

Just to be clear, it generates only 1000 samples and then stops, or generates only 1000 unique samples and then starts over with the same images?

Could you provide a reproducible test case?

[AghilesAzzoug]

I got the same issue and I just noticed that in GeneratorFromRandom class (from_random.py file) the __iter__ method is returning self.generator so the GeneratorFromRandom.__next__ will never be called (instead the GeneratorFromStrings.__next__ method will be).

A quick fix will be: 1st: returning self instead of self.generator in __iter__ method 2nd: add a generated_count variable and increment it in each __next__ call and throw a StopIteration when it reaches self.count 3rd: in GeneratorFromRandom.next method, when generated_count >= 999, create a new generator in self.generator.

You might find a more elegant way to solve this, but at least its quick and it does work.

Ps: there is the same problem in the Generator from Wikipedia.