linphone-desktop icon indicating copy to clipboard operation
linphone-desktop copied to clipboard

Dark Theme

Open KyronNextLevel opened this issue 4 years ago • 9 comments

From Gitlab (IT wrx) : "The new linphone-desktop theme is very nice and modern, but it's burning my eyes out. Please consider adding a choice for a dark version of it in the user interface section of the preferences.

Thanks"

KyronNextLevel avatar May 19 '20 09:05 KyronNextLevel

"dark version" or support for system themes

keha avatar Apr 12 '22 11:04 keha

a much needed feature

Tamarindo94 avatar Apr 21 '22 01:04 Tamarindo94

Count me in on this one too.

I would die for a dark theme.

UweKeim avatar Jun 13 '22 11:06 UweKeim

Count me in on this one too.

I would die for a dark theme.

I would kill for a dark theme dude

pwnwithlove avatar Jul 16 '22 23:07 pwnwithlove

Qt5 Configuration Tool

To add a dark theme to Linphone, I suggest considering using the already existing Qt5 Configuration Tool (qt5ct package) for Debian at https://packages.debian.org/en/bullseye/qt5ct

This screenshot below shows then suggested end result about how the end-users would set a dark theme. screenshot---qt5ct---francewhoa---ksnip---2022-08-11---113239

Any volunteer for a patch? Both me and the Ubertus.org team would be happy, as volunteer, to contribute testing and documentation, if needed.


Below is the same suggestion as above. But with details if you're interested in those.

One of many benefits with qt5ct is that the end-user only need to set the dark theme once. Then all QT application automatically use this dark theme. Another benefit with qt5ct is that it is also able to customize fonts and icons use by all QT apps.

This qt5ct package is available for most operating systems. Such as, but not limited to, Linux.

As you know, Linphone is powered by QT, this qt5ct utility allows users to, quickly and easily, configure Qt5 settings. Including theme, font, icons, etc.

Suggested steps to set dark theme using qt5ct on Debian 10 Buster:

  1. Linphone theme adapt Linphone to use qt5ct
  2. End-user install those four packages. Where adwaita means dark theme: adwaita-qt adwaita-qt-data adwaita-qt4 qt5ct
  3. Optionally, end user configure appropriately their .profile file. Which is located at /<DEBIAN USERNAME>/.profile. This is a one time action. Which can be done in Terminal using this command: echo "export QT_QPA_PLATFORMTHEME=qt5ct" >> ~/.profile
  4. End-user need to log-out the present GNOME session. This is needed to activate the new QT configuration.
  5. End-user log-in a new GNOME session
  6. End-user open qt5ct. In GNOME it's titled Qt5 Settings/Paramètres de QT
  7. End-user chooses any theme to their liking. In this example, this dark theme
  8. End-user close the GNOME window Qt5 Settings/Paramètres de QT
  9. End-user open Linphone
  10. Linphone is now displayed with a dark theme :)
  11. In the future, end-user does not need to redo all the other steps above. As those are one time configuration.

Francewhoa avatar Aug 11 '22 16:08 Francewhoa

Indeed, a dark theme is to me now a requirement. But this should be thought about in terms of existing ui elements and appearance, otherwise you get things like adwaita-dark, where you simply alter colors, which do to lack of proper contrast and removal of line guides in favor of dark gray background tones, I often find adwaita-dark rather unusable for readability.

dyfet avatar Sep 06 '22 10:09 dyfet

@Francewhoa this probably is not a simple a request. It is rather easy to make Qt widget apps detect and respect dark color theme settings on all desktop platforms (macos, windows, linux). In a way, unfortunately, modern releases of linphone now use qml and qml drawing controls rather than widgets. Hence, it does not seem to use nor tie to native controls and color schemes at all. The linphone ui now does look identical on windows and Linux, and as as out of place on windows with a dark theme as it does on desktop linux with one.

dyfet avatar Sep 08 '22 08:09 dyfet

Thanks for your comments @dyfet :) Interesting about qml and qml drawing controls rather than widgets. I did not know that Linphone was using those.

According to eyllanesc, a dark theme with qml and qml drawing controls could be done with the environment variable QT_QUICK_CONTROLS_MATERIAL_THEME. Related documentation at :

  • QT_QUICK_CONTROLS_MATERIAL_THEME environment variable at https://doc.qt.io/qt-5/qtquickcontrols2-environment.html
  • qtquickcontrols2.conf file at https://doc.qt.io/qt-5/qtquickcontrols2-configuration.html

Details in eyllanesc's comment at https://stackoverflow.com/a/67482382/8068060 or at https://archive.ph/DX2Fl Sebastian Kollmar has confirmed that this method above was successful for another product than Linphone.

As for adwaita-dark, my intention was to show one of many examples about how other products added a dark theme. In other words, it could be any other name or theme to the liking of the Linphone community. How about linphone-dark?

I'm not a developer or a themer. My strenghts are Product Manager services on demand. Any volunteer for a patch? Both me and the Ubertus.org team would be happy, as volunteer, to contribute testing and documentation, if needed.

Francewhoa avatar Sep 12 '22 14:09 Francewhoa

Aloha!

"Dark Theme" brings to light (heh) a deep consideration for the end-user, the non-numerical artist of whom a wax crayon, camel-hair brush or fine-scoop clay is their nomme-de-trade, their daily wax-on, wax-off of what works for them in their fencing instance.

"It ain't much but it's honest work." ~Jackson Pollock never said this.

Speaking to the above language of 'industry standards', I point the juris-sticky discriminating mind to the top-ranking sites presenting Dark Theme as more than a passing fancy, but a genuine carriage on an ever widening stagecoach road.

www.lovemyonlinemarketing.com/14-game-changing-web-design-trends-for-2024

https://bootcamp.uxdesign.cc/the-rise-of-dark-mode-a-design-trend-thats-here-to-stay-fdcacc28bd30?gi=3ef9d05a8233

https://wppool.dev/why-dark-mode-got-popular-in-tech-world/

Now, speaking to the Dark Mode of Linphone's Mobile platform, indeed, pleasing to the eyes is a well-dressed, stylish operating system, seated in her open-top buggy, her glorious, glamorous and flowing form now shaded from the glaring white-page florescent sky.

Well, OLED screens are nifty but plasma displays use glowing magnetic gas and that's cool. Like in those new hoverboards waiting to be invented.

However, much to the gorgeous, smiling GUI damsel's uninformed dismay, having to depart such a fine mobile platform onto well-shaded, plant-adorned, nearly tropical paradise stationed to transform her dusty travail unto a glorious rest-stop - wherein of course a lady may reconfigure herself at her own luxury... for such a station, upon her applicating the entrance opening - such a harsh and blazing radiance of foreign bleaching would appear!

This blazing light? Is it the paparazzi? The press? Her redneck cousin Earl from TN with the hunting lights on his truck? NO!

It's merely someone's idea of hijacking the entire platform from under the gracious lady's lovely feet.

Y'all's idea of applying an App Image for Ubuntu's GUI, devoid of connection amid the established GUI platform's tropical theme, vicariously ignoring the Human_Person's_Preference - it certainly would seem there are better ways to treat a lady!

And if there's anything a girl needs more than to talk on the phone, it's a cool, dark place to pretty herself in private. Ahem

So, with that, I ask Please! Produce an upgrade to The Linphone 5.2.x App Image with a customizeable GUI interface towards a color pallete of the Human's choice.

This way, a girl can make it match her eyeliner.

It keeps me from using line-backer's cheek blocker in functional salute to AND from the glare.

Unless the shoulder pads tone my mood with an AI, those went out with the Mall Claw and the Mullet, sweetie.

Please and thank you and here's to making the world more beautiful, one low-contrast screen-at-time.

XOXOXO

Your friendly Neighborhood GUI Desktop crayon scribbler. Y'know, at the dark end of the Elm Street.

Linphone-MakeDestopDark avatar Feb 09 '24 22:02 Linphone-MakeDestopDark