BOSL2 icon indicating copy to clipboard operation
BOSL2 copied to clipboard
verified publisher icon BelfrySCAD

cleanup: many unused definitions in threading.scad

Open coryrc opened this issue 4 months ago • 3 comments

  • https://github.com/BelfrySCAD/BOSL2/blob/d252f781232a9262583806fe05bbb8529c108899/threading.scad#L1255
  • https://github.com/BelfrySCAD/BOSL2/blob/d252f781232a9262583806fe05bbb8529c108899/threading.scad#L253
  • https://github.com/BelfrySCAD/BOSL2/blob/d252f781232a9262583806fe05bbb8529c108899/threading.scad#L376

I've only run across these randomly and have not thoroughly searched for more.

Quick Google search, maybe https://pypi.org/project/sca2d can find unused variables? It also looks actively-worked-on so it may soon if it doesn't already.

coryrc avatar Aug 17 '25 02:08 coryrc

I think oprofile was probably left behind in case I needed to revert or reference the previous profile definition. Probably can be deleted now.

adrianVmariano avatar Aug 17 '25 20:08 adrianVmariano

If you want to submit a PR that removes the many oprofile definitions and the one reference to depth that's not used I'll merge it.

adrianVmariano avatar Aug 21 '25 23:08 adrianVmariano

Thanks, if nobody else gets to it, I will in the next few weeks.

coryrc avatar Aug 22 '25 14:08 coryrc