VoiceInk icon indicating copy to clipboard operation
VoiceInk copied to clipboard

Add clear build instructions

Open maelp opened this issue 8 months ago • 10 comments
trafficstars

Originally posted by @maelp in #17

Could be nice to have complete build instructions (see for instance the linked comment for details on how I managed to build it)

maelp avatar Mar 18 '25 10:03 maelp

Yeah, sure. I think whisper.cpp has updated their build instructions as well. So it is different than what I used previously.

These instructions are simpler and easier to implement. So I'll definitely update it.

Beingpax avatar Mar 18 '25 13:03 Beingpax

Perhaps instead of having the user build whisper.cpp you could use https://swiftpackageindex.com/exPHAT/SwiftWhisper (don't know if it's up-to-date)

maelp avatar Mar 20 '25 16:03 maelp

I don't think it's up to date. Even when I started building VoiceInk for the first time, I was thinking of using Swift Whisper, but it was not up to date.

That's why I didn't use it.

On Thu, Mar 20, 2025 at 10:20 PM Mael @.***> wrote:

Perhaps instead of having the user build whisper.cpp you could use https://swiftpackageindex.com/exPHAT/SwiftWhisper (don't know if it's up-to-date)

— Reply to this email directly, view it on GitHub https://github.com/Beingpax/VoiceInk/issues/18#issuecomment-2741052899, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYCUXQFG7HEWUDLA2G443ZL2VLU3TAVCNFSM6AAAAABZHYY5JGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBRGA2TEOBZHE . You are receiving this because you commented.Message ID: @.***> [image: maelp]maelp left a comment (Beingpax/VoiceInk#18) https://github.com/Beingpax/VoiceInk/issues/18#issuecomment-2741052899

Perhaps instead of having the user build whisper.cpp you could use https://swiftpackageindex.com/exPHAT/SwiftWhisper (don't know if it's up-to-date)

— Reply to this email directly, view it on GitHub https://github.com/Beingpax/VoiceInk/issues/18#issuecomment-2741052899, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYCUXQFG7HEWUDLA2G443ZL2VLU3TAVCNFSM6AAAAABZHYY5JGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBRGA2TEOBZHE . You are receiving this because you commented.Message ID: @.***>

Beingpax avatar Mar 20 '25 16:03 Beingpax

Indeed, but if you look at his code, it's quite clean, he's doing the "submodule" thing to include whisper (we should just put a more recent version) and symlinking the proper files from there so they are found easily... I guess it shouldn't be too hard to either update his code, or use the same stuff, but in VoiceInk repo https://github.com/exPHAT/SwiftWhisper

maelp avatar Mar 20 '25 16:03 maelp

Here he is using a submodule to directly include whisper.cpp in his repo

Image

maelp avatar Mar 20 '25 16:03 maelp

Here he seems to symlink the proper files to find them directly without drag-and-dropping the framework

Image

but perhaps we could just:

  • add a git submodule for whisper
  • tell people to build it like you did in the README
  • then just add a symlink for the .xcframework so people don't need to do the drag-and-drop

maelp avatar Mar 20 '25 16:03 maelp

If you look at the fork of his repo, there are a few that have been recently updated, like https://github.com/ChippStudio/SwiftWhisper, perhaps those work better

https://github.com/exPHAT/SwiftWhisper/forks

maelp avatar Mar 20 '25 16:03 maelp

I will take a look into this tomorrow.

On Thu, 20 Mar 2025 at 22:36 Mael @.***> wrote:

If you look at the fork of his repo, there are a few that have been recently updated, like https://github.com/ChippStudio/SwiftWhisper, perhaps those work better

https://github.com/exPHAT/SwiftWhisper/forks

— Reply to this email directly, view it on GitHub https://github.com/Beingpax/VoiceInk/issues/18#issuecomment-2741096161, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYCUXQELPE4VQX5AJH3SRAD2VLWZXAVCNFSM6AAAAABZHYY5JGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBRGA4TMMJWGE . You are receiving this because you commented.Message ID: @.***> [image: maelp]maelp left a comment (Beingpax/VoiceInk#18) https://github.com/Beingpax/VoiceInk/issues/18#issuecomment-2741096161

If you look at the fork of his repo, there are a few that have been recently updated, like https://github.com/ChippStudio/SwiftWhisper, perhaps those work better

https://github.com/exPHAT/SwiftWhisper/forks

— Reply to this email directly, view it on GitHub https://github.com/Beingpax/VoiceInk/issues/18#issuecomment-2741096161, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYCUXQELPE4VQX5AJH3SRAD2VLWZXAVCNFSM6AAAAABZHYY5JGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBRGA4TMMJWGE . You are receiving this because you commented.Message ID: @.***>

Beingpax avatar Mar 20 '25 17:03 Beingpax

@Beingpax, please consider updating build instructions, the last version I managed to build using existing one is 1.34, newer ones do produce errors. :(

iAdanos avatar Jul 16 '25 09:07 iAdanos

Thanks to @slumdev88 and their fixes here, I'm again able to build past v1.34, and just built v1.53.

Spotted while randomly reading their contributed PR https://github.com/Beingpax/VoiceInk/pull/163.

They expertly update parts of //VoiceInk/Services/NativeAppleTranscriptionService.swift which appears to resolve all our build errors.

tamsky avatar Sep 04 '25 07:09 tamsky