BehaviorTree.ROS2 icon indicating copy to clipboard operation
BehaviorTree.ROS2 copied to clipboard

Add QoS configuration to RosNodeParams

Open rafal-gorecki opened this issue 1 year ago • 5 comments

I really like this pkg and the way it was created. Bravo to the authors!

The only thing missing is the ability to set QoS for topics. By the way, I also added the ability to change the qos_profile for services.

I found other solutions with similar themes, which may be updated if this PR passes:

  • https://github.com/BehaviorTree/BehaviorTree.ROS2/issues/14
  • https://github.com/BehaviorTree/BehaviorTree.ROS2/pull/95

rafal-gorecki avatar Oct 21 '24 16:10 rafal-gorecki

Hello @tony-p @facontidavide, Can I ask one of u guys for review?

rafal-gorecki avatar Oct 24 '24 10:10 rafal-gorecki

I'm not a maintainer so can't push this further. My first thought was why not define the qos in the node implementation as it will typically be constant for a particular message type, but on reflection I think adding to the params probably does make more sense.

tony-p avatar Nov 14 '24 21:11 tony-p

Hi @facontidavide, I see that you made the last change in this repo. Is it possible for you to check these changes?

rafal-gorecki avatar Mar 13 '25 14:03 rafal-gorecki

@rafal-gorecki Would love to get this merged, there is a small fix here to merge into this branch: https://github.com/rafal-gorecki/BehaviorTree.ROS2/pull/1/files.

EricDavidWells avatar Jul 10 '25 18:07 EricDavidWells

I merge it, thanks @EricDavidWells

rafal-gorecki avatar Jul 11 '25 07:07 rafal-gorecki