MinkExtension icon indicating copy to clipboard operation
MinkExtension copied to clipboard

Support for Symfony 5.x

Open didix16 opened this issue 5 years ago • 10 comments

Hi guys,

Could be possible the compatibility with symfony 5.x configs?

I'm trying to install Laravel 7 which uses symfony 5 components but minkextension is only compatible till symfony 4.

Thanks in advance

didix16 avatar Mar 18 '20 10:03 didix16

I have just done a pull request for this and I am in your same case. I submit it and I give it a try on my project ASAP and give you my feedback on it.

chadyred avatar Mar 18 '20 11:03 chadyred

It works like a charm so I wait for merge !

chadyred avatar Mar 18 '20 11:03 chadyred

Perfect, thank you so much!

didix16 avatar Mar 18 '20 11:03 didix16

You could use this branch if you want : cdaguerre:sf-5-compat. Their are 2 other PR on this subjet, I close mine in favorite of this one : https://github.com/Behat/MinkExtension/issues/361 !

chadyred avatar Mar 19 '20 09:03 chadyred

Ok, thanks. I'll try to use that branch. Let's see if it works with my project :)

didix16 avatar Mar 19 '20 14:03 didix16

Does any one have a solution to make it run on Symfony 5.x ?

AmokraneMancer avatar Apr 08 '20 02:04 AmokraneMancer

In your composer.json, to resolve this issue use my github repo that fix this dependencies:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/chadyred/MinkExtension"
        }
    ],
    "require-dev": {
        "behat/mink-extension": "dev-upgrade/allow-symony-5 as 2.3",
    }
}

chadyred avatar Apr 08 '20 08:04 chadyred

@AmokraneMancer up

chadyred avatar Apr 08 '20 11:04 chadyred

Thank you so much @chadyred. it works perfectly !

AmokraneMancer avatar Apr 08 '20 15:04 AmokraneMancer

You're welcome !

chadyred avatar Apr 09 '20 11:04 chadyred

Can't make it work as @chadyred suggested:

# composer.json
"require-dev": {
    "behat/mink-extension": "dev-upgrade/allow-symony-5 as 2.3",
...
# CLI
$: composer-2 update
Loading composer repositories with package information
Info from https://repo.packagist.org: #StandWithUkraine
Restricting packages listed in "symfony/symfony" to "5.4.*"
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires behat/mink-extension dev-upgrade/allow-symony-5 as 2.3, found behat/mink-extension[dev-master, v1.0.0, ..., 1.3.x-dev, v2.0.0, ..., 2.x-dev (alias of dev-master)] but it does not match the constraint.

mellowgrab avatar Feb 11 '23 23:02 mellowgrab

Did you add this in your composer.json

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/chadyred/MinkExtension"
        }
    ],

chadyred avatar Feb 14 '23 14:02 chadyred

I tried that with no luck tho. In the end I've switched to https://github.com/FriendsOfBehat/MinkExtension which works just fine without the need of aliasing and stuff.

mellowgrab avatar Feb 14 '23 14:02 mellowgrab

You are right, this is the best way as the https://github.com/FriendsOfBehat/MinkExtension is the main repository for MinkExtension and the maintain repository

chadyred avatar Feb 14 '23 14:02 chadyred