MinkExtension icon indicating copy to clipboard operation
MinkExtension copied to clipboard

Published 20 hours ago • verified publisher icon Behat

Xdebug support in PHPStorm

Open haringsrob opened this issue 7 years ago • 6 comments

Hi,

This is an initial proposal to add PHPstorm xdebug integration.

Current situation is that, you can debug behat as long as calls are direct, however, once http requests are involved like When I am on "\" then the debugger will no longer continue as no cookie is set.

This pull requests solves this by checking if the xdebug_config server variable is set, if that is the case, the session will receive the xdebug cookie allowing the debugger to work.

~~I have included internations/http-mock to mock a php webserver, we could update the other feature to use this as well. But let's handle that separate.~~

~~Travis is failing because internations/http-mock requires php7.. I'll see if I can test this in a different way.~~

Http mocking was not needed, still it is weird to use an online domain to do this.

Suggestions are welcome.

haringsrob avatar Jun 07 '17 20:06 haringsrob

Tests are failing because of external dependency's, I would drop php 5.3 support.

haringsrob avatar Jun 07 '17 20:06 haringsrob

You should not use short array syntax to get compatible with php 5.3

spolischook avatar Jun 07 '17 21:06 spolischook

Hello @spolischook,

Changes are made.

As for your second comment, there is no short array syntax used anywhere in my commit.

haringsrob avatar Jun 08 '17 05:06 haringsrob

Hello @stof,

Thanks for the review, makes sense.

Changes have been applied.

haringsrob avatar Jun 08 '17 07:06 haringsrob

@haringsrob any way you need to fix tests before merge your impruvement https://travis-ci.org/Behat/MinkExtension/jobs/240659573#L350 Also, please remove hhvm from travis.yml, because it's not supported by travis-ci any more. https://travis-ci.org/Behat/MinkExtension/jobs/240659577

spolischook avatar Jun 08 '17 08:06 spolischook

@spolischook I will remove the hhvm.

For the other part I don't agree, PHP Parse error: syntax error, unexpected '[' in /home/travis/build/Behat/MinkExtension/vendor/behat/behat/src/Behat/Testwork/Argument/MixedArgumentOrganiser.php on line 288 As behat is no going to support php 5.3 anymore, why should we?

Also php 5.3 is already EOL for some time, http://php.net/eol.php, keeping on using it might give developer the wrong idea that it is ok.

haringsrob avatar Jun 08 '17 10:06 haringsrob